On Monday, November 17, 2014 08:41:20 AM Wang, Shuo wrote: > Because the token "#version 300 es " is necessary with the current infrastructure during a GLSL ES30 shader test is added. > > This patch is used to make it more automation, and the infrastructure can now adding "#version 300 es" itself, when the GLSL ES30 shader do not include the token. > > Signed-off-by: Wang Shuo <[email protected]> > --- > tests/glslparsertest/glslparsertest.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-)
For what it's worth, I don't like this plan. Currently, glslparsertest doesn't add a #version for you implicitly - you have to write it as the first line of the shader. I like this, because there's no magic - you write what you mean. The .vert or .frag file contains a complete shader that could be parsed by any tools. All of our tests already specify "#version 300 es" explicitly. shader_runner does implicitly add a #version for you, but glslparsertest never has. --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
