On Monday, November 17, 2014 08:29:35 PM Ilia Mirkin wrote: > On Mon, Nov 17, 2014 at 7:12 PM, Dylan Baker <[email protected]> wrote: > > On Monday, November 17, 2014 04:00:25 PM Ben Widawsky wrote: > >> Signed-off-by: Ben Widawsky <[email protected]> > >> --- > >> tests/all.py | 13 +++++++++++++ > >> 1 file changed, 13 insertions(+) > >> > >> diff --git a/tests/all.py b/tests/all.py > >> index f2c5c1f..796cc0f 100644 > >> --- a/tests/all.py > >> +++ b/tests/all.py > >> @@ -3647,6 +3647,19 @@ import_glsl_parser_tests(spec['ARB_compute_shader'], > >> ['compiler']) > >> arb_compute_shader['built-in constants'] = > >> PiglitGLTest('built-in-constants ' + os.path.join(testsDir, > >> 'spec/arb_compute_shader/minimum-maximums.txt'), run_concurrent=True) > >> > >> +arb_pipeline_statistics = {} > >> +spec['ARB_pipeline_statistics'] = arb_pipeline_statistics > >> +arb_pipeline_statistics['arb_pipeline_stats_vs_basic_stats'] = \ > >> + PiglitGLTest('arb_pipeline_stats_vert', run_concurrent=True) > >> +arb_pipeline_statistics['arb_pipeline_stats_vs_adjacent_stats'] = \ > >> + PiglitGLTest('arb_pipeline_stats_vert_adj', > >> run_concurrent=True) > >> +arb_pipeline_statistics['arb_pipeline_stats_gs_basic_stats'] = \ > >> + PiglitGLTest('arb_pipeline_stats_geom', run_concurrent=True) > >> +arb_pipeline_statistics['arb_pipeline_stats_clip_basic_stats'] = \ > >> + PiglitGLTest('arb_pipeline_stats_clip', run_concurrent=True) > >> +arb_pipeline_statistics['arb_pipeline_stats_fs_basic_stats'] = \ > >> + PiglitGLTest('arb_pipeline_stats_frag', run_concurrent=True) > >> + > > > > Two comments for you: > > 1) we generally add tests to all.py in the same commit we add the test > > 2) no tabs in the python code, please use 4 tab indent. > > 4-space is probably better. 32 spaces feels excessive :)
lol. Yeah, 4 spaces.
>
> >
> >> # group glslparsertest
> >> ------------------------------------------------------
> >> glslparsertest = {}
> >> # Add all shader source files in the directories below.
> >> --
> >> 2.1.3
> >>
> >> _______________________________________________
> >> Piglit mailing list
> >> [email protected]
> >> http://lists.freedesktop.org/mailman/listinfo/piglit
> >>
> >
> > _______________________________________________
> > Piglit mailing list
> > [email protected]
> > http://lists.freedesktop.org/mailman/listinfo/piglit
> >
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
