For this and 2/4, I think it might be safer to add some assertions for config.window_*, like
assert(config.window_width >= (((BOX_SIZE+1)*TEST_COLS)+1)); ... Just in case the default window size becomes smaller in the future. Or put the MAX2 like you did on 4/4. Otherwise series looks good to me. Jose ----- Original Message ----- > --- > tests/shaders/fp-abs-01.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/shaders/fp-abs-01.c b/tests/shaders/fp-abs-01.c > index 0b59829..411c29b 100644 > --- a/tests/shaders/fp-abs-01.c > +++ b/tests/shaders/fp-abs-01.c > @@ -37,9 +37,6 @@ > PIGLIT_GL_TEST_CONFIG_BEGIN > > config.supports_gl_compat_version = 10; > - > - config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1); > - config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1); > config.window_visual = PIGLIT_GL_VISUAL_DOUBLE; > > PIGLIT_GL_TEST_CONFIG_END > -- > 1.7.10.4 > > _______________________________________________ > Piglit mailing list > [email protected] > https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=QaeJ7acE7C2DLaveQ73T3LuXzQpF11Ugc3cDrPk%2FCvo%3D%0A&s=3b97f788307a84aba347199fae57fcff2431a3d8ec43a6153fccf73a759cc38e > _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
