On Tue, May 27, 2014 at 9:16 AM, Brian Paul <[email protected]> wrote: > On 05/24/2014 05:31 PM, Emil Velikov wrote: >> >> On 24/05/14 22:10, Ilia Mirkin wrote: >>> >>> Signed-off-by: Ilia Mirkin <[email protected]> >>> --- >>> >>> This doesn't actually end up mattering for the GLX tests because they do >>> a >>> substr-based search in the overall extension string. But for the GL tests >>> it >>> matters because it looks for exact matches in an array. >>> >>> May as well fix the GLX tests while I'm at it, in case they ever move to >>> the >>> array mechanism. >>> >> Nice catches Ilia. >> >> With this patch - all egl, gl and glx extensions have their respective >> prefix. >> This way people (like me) should have less of a incentive to forget them. > > > Maybe the piglit_require_extension() functions should assert that the first > two characters of the string are "GL".
I guess each require_extension variant has its required prefix, right? piglit_require_extension -> "GL_" piglit_require_glx_extension -> "GLX_" piglit_require_egl_extension -> "EGL_" If that's indeed the case, seems easy enough to add to tests/util/piglit-*-util.c -ilia _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
