On Monday, February 24, 2014 04:56:59 PM Thomas Wood wrote: > From: Damien Lespiau <[email protected]> > > Signed-off-by: Damien Lespiau <[email protected]> > --- > framework/core.py | 3 +++ > framework/summary.py | 1 + > templates/testrun_info.mako | 6 ++++++ > 3 files changed, 10 insertions(+) > > diff --git a/framework/core.py b/framework/core.py > index 2cb2216..4057502 100644 > --- a/framework/core.py > +++ b/framework/core.py > @@ -254,11 +254,13 @@ class TestrunResult: > self.serialized_keys = ['options', > 'name', > 'tests', > + 'uname', > 'wglinfo', > 'glxinfo', > 'lspci', > 'time_elapsed'] > self.name = None > + self.uname = None > self.options = None > self.glxinfo = None > self.lspci = None > @@ -405,6 +407,7 @@ class Environment: > else: > result['glxinfo'] = self.run('glxinfo') > if system == 'Linux': > + result['uname'] = self.run(['uname', '-a'])
Suggestion: uname -a works on *BSD and OSX, so put it in the else block above?
(that else is for not windows)
> result['lspci'] = self.run('lspci')
> return result
>
> diff --git a/framework/summary.py b/framework/summary.py
> index c1104c3..528182d 100644
> --- a/framework/summary.py
> +++ b/framework/summary.py
> @@ -382,6 +382,7 @@ class Summary:
> out.write(testindex.render(name=each.name,
>
> time=str(timedelta(0,each.time_elapsed)), options=each.options,
> + uname=each.uname,
> glxinfo=each.glxinfo,
> lspci=each.lspci))
>
> diff --git a/templates/testrun_info.mako b/templates/testrun_info.mako
> index e6e00b3..6ff1f44 100644
> --- a/templates/testrun_info.mako
> +++ b/templates/testrun_info.mako
> @@ -30,6 +30,12 @@
> <td>${options}</td>
> </tr>
> <tr>
> + <td>uname -a</td>
> + <td>
> + <pre>${uname}</pre>
> + </td>
> + </tr>
> + <tr>
> <td>lspci</td>
> <td>
> <pre>${lspci}</pre>
For this patch with or without my suggestion:
Reviewed-by: Dylan Baker <[email protected]>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
