Hi Kenneth,

In addition to a couple patches which I just posted, I think there's some more loose ends in this test.

Basically, the test_proxy_texture_size test determines the maximum texture size that passes the proxy test. I think we want to use that info when we do the test_non_proxy_texture_size() test to see if we can really allocate a texture of the max size and write something into it.

As it is now I get results like this (just looking at 3D textures):

[...]
GL_PROXY_TEXTURE_3D, Internal Format = GL_RGBA8, Largest Texture Size = 612
PIGLIT:subtest {'GL_PROXY_TEXTURE_3D-GL_RGBA8' : 'pass'}
GL_PROXY_TEXTURE_3D, Internal Format = GL_RGBA16, Largest Texture Size = 488
PIGLIT:subtest {'GL_PROXY_TEXTURE_3D-GL_RGBA16' : 'pass'}
GL_PROXY_TEXTURE_3D, Internal Format = GL_RGBA32F, Largest Texture Size = 388
PIGLIT:subtest {'GL_PROXY_TEXTURE_3D-GL_RGBA32F' : 'pass'}
[...]

GL_TEXTURE_3D, Internal Format = GL_RGBA8, Largest Texture Size = 2048
Error allocating texture data array for target GL_TEXTURE_3D, size 1024
PIGLIT:subtest {'GL_TEXTURE_3D-GL_RGBA8' : 'skip'}
GL_TEXTURE_3D, Internal Format = GL_RGBA16, Largest Texture Size = 2048
Error allocating texture data array for target GL_TEXTURE_3D, size 1024
PIGLIT:subtest {'GL_TEXTURE_3D-GL_RGBA16' : 'skip'}
GL_TEXTURE_3D, Internal Format = GL_RGBA32F, Largest Texture Size = 2048
Error allocating texture data array for target GL_TEXTURE_3D, size 1024
PIGLIT:subtest {'GL_TEXTURE_3D-GL_RGBA32F' : 'skip'}


Instead of getting 'skip' results, I think we'd rather see pass, fail or crash when testing the 612 or 488 or 388 max size.

What do you think?  I'll try writing a patch for that...

-Brian
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to