Sorry, this patch is incorrect.  I have send the correct one. Please ignore it.

From: Ken Phillis Jr [mailto:[email protected]]
Sent: Wednesday, December 11, 2013 11:36 AM
To: Jin Zhou
Cc: [email protected]; Zhou, Jin
Subject: Re: [Piglit] [PATCH] fix the fbo bind error check. a 
GL_INVALID_OPERATION error should be generated, instead of GL_INVALID_VALUE

I think this patch needs to be reworked. I believe there should be more than 
just adding a blank line.

On Mon, Dec 9, 2013 at 4:44 AM, Jin Zhou 
<[email protected]<mailto:[email protected]>> wrote:
From: Jin Zhou<[email protected]<mailto:[email protected]>>

diff --git a/tests/fbo/fbo-bind-renderbuffer.c 
b/tests/fbo/fbo-bind-renderbuffer.c
index 50c8c7f..3b2b305 100644
--- a/tests/fbo/fbo-bind-renderbuffer.c
+++ b/tests/fbo/fbo-bind-renderbuffer.c
@@ -64,6 +64,7 @@ test_binding(GLboolean bindRenderbuffer)
                                 GL_RENDERBUFFER_EXT, rb);

    err = glGetError();
+
    return err;
 }

--
1.7.9.5

_______________________________________________
Piglit mailing list
[email protected]<mailto:[email protected]>
http://lists.freedesktop.org/mailman/listinfo/piglit

_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to