On 05/17/2013 09:32 AM, Dylan Baker wrote:
When comparing two test results the current behavior sets a status of
skip for tests that were not run in one set of results. This is
confusing and silly, so instead give them a status of N/A which gives a
clear understanding of what skipped, and what simply didn't run either
by exclusion or because it didn't exist yet.

Signed-off-by: Dylan Baker <[email protected]>
---
  framework/summary.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/summary.py b/framework/summary.py
index 6780458..0702319 100644
--- a/framework/summary.py
+++ b/framework/summary.py
@@ -417,7 +417,7 @@ class BuildHTMLIndex(list):
                      self._testResult(each.name, key, 
each.tests[key]['result'])
                  except KeyError:
                      self.append({'type': 'other',
-                                 'text': '<td class="skip">skip</td>'})
+                                 'text': '<td class="skip">N/A</td>'})
              self._endRow()

      def _newRow(self):

Changing this sounds good, but could we perhaps call it "not run"?

I'm afraid I might get confused about whether "N/A" means "not run" or "this test isn't relevant because it's not supported by your driver".
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to