One thing I would do different is:

switch ($fcol){

case 000:

break;

case 050:

break;

default:

break;
}

To me the switch/case code is easier to read/maintain.

I know that doesn't actually solve your repetition problem but it will make
it a little easier to look at.

John Guynn

This email brought to you by RFCs 821 and 1225.


-----Original Message-----
From: Ashley M. Kirchner [mailto:[EMAIL PROTECTED]]


    Is there a better way to write the following snippet:

    if ($priority == "000") {
      $fcol="high";
      $pstr .= "<option value=\"000\" selected>High\n";
      $pstr .= "<option value=\"050\">Medium\n";
      $pstr .= "<option value=\"100\">Low\n";
    } elseif ($priority == "050") {
      $fcol="med";
      $pstr .= "<option value=\"000\">High\n";
      $pstr .= "<option value=\"050\" selected>Medium\n";
      $pstr .= "<option value=\"100\">Low\n";
    } else {
      $fcol="low";
      $pstr .= "<option value=\"000\">High\n";
      $pstr .= "<option value=\"050\">Medium\n";
      $pstr .= "<option value=\"100\" selected>Low\n";
    }

    I just hate having to repeat pieces of code.  This piece here just
generates a drop down list of items, with the current one being the
selected one.

-- 
PHP General Mailing List (http://www.php.net/)
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to