I suggest you take everyone's advice and use one of the thousand database abstraction objects.
At the very least, look at how they are put together. This one is an excellent example: http://pear.php.net/package/DB "Andy B" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > makes since... i think would i would probably do is define the > error/errormsg stuff at the beginning of the class that way all functions > can use it?? > > class DbConnection { > var $ErrorNumber; > var $ErrorMsg; > function Connect(.....){ > $link=mysql_connect(...); > if(!$link){ > $ErrorNumber=mysql_errno(); > //and the msg itself if we want > $ErrorMsg=mysql_error(); > return false;} > else{return $link;}} > > or however the best way goes for that... > > ----- Original Message ----- > From: "Curt Zirzow" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Thursday, April 15, 2004 1:35 AM > Subject: Re: [PHP] mysql connect function in my class > > > > * Thus wrote Andy B ([EMAIL PROTECTED]): > > > hi.... > > > i have this function inside a class that im writing that eventually i > want > > > to put inside a package of my own... the function goes like this: > (comment > > > block included): > > > > > > /** > > > *function Connect: open connection to database. > > > * > > > [EMAIL PROTECTED] string $host mysql hostname to connect to > > > [EMAIL PROTECTED] string $mysqluser name of the mysql user to login with > > > [EMAIL PROTECTED] string $mysqlpwd the users password for mysql server > > > [EMAIL PROTECTED] resource|false > > > */ > > > > > > function Connect($host, $mysqluser, $mysqlpwd){ > > > $link=mysql_connect($host, $mysqluser, $mysqlpwd) > > > if(!$link){ return false; } > > > else { return $link; }} > > > > > should i keep it like this or is it better for the function itself to > deal > > > with error handling at the same time? i.e. should it return an error > > > message/number or something of that sort or give the returned resource > over > > > to some other function that deals with errors.... > > > > A standard database layer will return false, and set a error code > > and error message property, so the application using the class can > > do something about it. > > > > > > if (! $link = mysql_connect($host..) ) { > > $this->error = mysql_errno(); > > $this->error_msg = mysql_error(); > > return false; > > } > > ... > > > > Then in the application: > > > > if (! $dbh = $db->Connect(blah...) ) { > > echo $db->error, ': ', $db->error_msg; > > exit; > > } > > > > > > > > Curt > > -- > > "I used to think I was indecisive, but now I'm not so sure." > > > > -- > > PHP General Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
