Hi all. I noticed this morning that this PRs had been merged against PSR-12:
https://github.com/php-fig/fig-standards/pull/1185 https://github.com/php-fig/fig-standards/pull/1183 I do not believe the changes in them are appropriate for an already-voted-on PSR. Changes post-vote are permitted in only very narrow circumstances: https://www.php-fig.org/bylaws/psr-amendments/#3-acceptable-amendments The following changes in that PR go well beyond Annotations or Formatting & Typos: https://github.com/php-fig/fig-standards/pull/1185/files Changing "would not" (a non-binding term) to a "MUST NOT" (an RFC defined term with very specific meaning) is a substantive change. The original "Would not" language is, in context, entirely adequate. https://github.com/php-fig/fig-standards/pull/1183/files#diff-53ccbb40a68e167a66735993f78e0bb9L99 This block changes the meaning of the spec, and thus is not allowed. https://github.com/php-fig/fig-standards/pull/1183/files#diff-53ccbb40a68e167a66735993f78e0bb9L369 Because capitalized MUST has a specific "legal" meaning, this is also technically a substantive change. https://github.com/php-fig/fig-standards/pull/1183/files#diff-53ccbb40a68e167a66735993f78e0bb9L439 Substantive change, and isn't even explained. https://github.com/php-fig/fig-standards/pull/1183/files#diff-53ccbb40a68e167a66735993f78e0bb9L464 While this is a net-zero impact change because the language already requires it, I would still say it's more than is allowed without an errata. https://github.com/php-fig/fig-standards/pull/1183/files#diff-53ccbb40a68e167a66735993f78e0bb9L689 These buts don't really add anything. (Insert inappropriate joke here.) https://github.com/php-fig/fig-standards/pull/1183/files#diff-53ccbb40a68e167a66735993f78e0bb9L885 This change is even noted in the comments as being a substantive change. This is not acceptable post-vote. https://github.com/php-fig/fig-standards/pull/1183/files#diff-53ccbb40a68e167a66735993f78e0bb9R918 I... don't even know what this is about at all. As a result, what is currently published as PSR-12 is not what was approved by the Core Committee. That situation must be corrected. I ask the Secretaries to revert both PRs promptly. Additionally, I do not believe PRs to approved specs should be merged by anyone other than the Secretaries, as they are the ones nominally responsible for typo-fix level changes. There are some non-substantive changes in the larger one that are fine (adding newlines and fixing some commas or capitalization), which can be resubmitted. Any substantive changes must go through an Errata vote, and if approved added to the meta document. (Note: I am not making any statement here on the substance of those changes, and whether they're good or bad for the spec. Just that they are inappropriate at this time.) -- Larry Garfield [email protected] -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/48c58f56-2f61-4d02-9b04-ef7f71fd3de4%40www.fastmail.com.
