Hello Matthew! As far as I'm aware, we never retracted the review period, but it was incredibly long. A big portion of that was getting two implementations ready for the final acceptance vote. We had talked back in March internally about going to the Acceptance vote, but needed the implementations. Unfortunately, since this was not just a set of interfaces, we had to get working style guide rules ready to go, and we wanted to make sure they were ready for big-named style checkers.
During the review process we merged in a handful of grammar/typo PRs, but functionality-wise only changed the following: - Body must start on line after an opening brace [1] This was added to provide consistency with the rule about no black lines between the end of a body and a closing brace, and it was decided that this would not be a major amount of work to implement for the reference implementations. As for feedback, I believe that was taken care of in the two threads[2][3]. The only major things that have come up (actually right after we called for the Acceptance vote) are the accessibility debate on tabs vs spaces and 7.4 support. We've decided that since PSR-12 is based on PSR-2, tabs vs spaces is outside of this PSR and will not be making that change as part of PSR-12. I've also decided that since 7.4 is not released, we will not be considering the syntax changes for it. -Chris [1] https://github.com/php-fig/fig-standards/pull/1164 [2] https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!searchin/php-fig/PSR-12%7Csort:date/php-fig/jHf53u6PzHM/Ko9d8OR7BQAJ [3] https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!searchin/php-fig/PSR-12%7Csort:date/php-fig/p94Hef2_ymA/ZkAfXwGhDAAJ On Tue, Jul 30, 2019 at 6:39 PM Matthew Weier O'Phinney < [email protected]> wrote: > Hi Chris! > > I don't recall seeing a review period. There was one some time ago > (February), but my understanding was that it was retracted once some > feedback came in (most recent was May). IIRC, we're supposed to reopen the > review period if we don't go directly to the acceptance vote. > > Regardless, can you summarize what changes were made since then, and what, > if any, feedback was addressed? > > Thanks! > > On Fri, Jul 26, 2019, 10:10 AM Chris Tankersley <[email protected]> > wrote: > >> Finally, after a very long review period and much discussion and >> tweaking, I think we are finally ready for the acceptance vote for PSR-12. >> >> The specification can be found here: >> >> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md >> >> And the meta document here: >> >> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md >> >> Thank you to everyone involved! >> >> -- >> Chris Tankersley >> http://ctankersley.com >> >> -- >> You received this message because you are subscribed to the Google Groups >> "PHP Framework Interoperability Group" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com >> <https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "PHP Framework Interoperability Group" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/php-fig/CAJp_myWGb%3DCfYwhW7YRB5ADUx%3DJ%3Dov%3Dy4tp-dq0eTKPrOaTJFQ%40mail.gmail.com > <https://groups.google.com/d/msgid/php-fig/CAJp_myWGb%3DCfYwhW7YRB5ADUx%3DJ%3Dov%3Dy4tp-dq0eTKPrOaTJFQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Chris Tankersley http://ctankersley.com -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAL9n4XOdZydJT6UyNROYfYnCEhfzsKLmuToP%2BykzDnTB1SSTdQ%40mail.gmail.com.
