Thank you for your efforts here Vinor, it's very much appreciated! I do disagree with the idea that we should require a new line, instead we should continue to leave it up to the implementor of PSR-12 whether they'd like a newline or not. I've added this discussion to the meta document for anyone that comes across this issue and is wondering what the best way to handle this is: https://github.com/php-fig/fig-standards/pull/939
Best wishes, Korvin On Thursday, September 28, 2017 at 1:22:05 AM UTC-7, Vinor cola wrote: > > Please check this: https://youtu.be/ZsHMHukIlJY?t=1319 (watch few > minutes, especially where the guy replace the code with X) > > Understand that visualy, a parenthesis is not enough to quickly make a > block distinction. This is a matter of readability: you cannot at a glance > get where parameters ends and where code starts. You said PS-12 allow new > lines after opening bracket. I think in this particular context, it should > make the new line mandatory. > -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/f8227106-6c78-4266-93e6-8e507784c3d3%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
