-1 PyroCMS I believe the interface designation is important. While the instance is being passed I think it's important to explicitly designate what is expected despite behind the scenes. To refer to another members car example - an Interface is not a Car - it's a CarInterface the "class Car implements CarInterface" OR "Ferrari implements CarInterface" not FerrariCar. However "Ferrari extends Car" would work if "Car implements CarInterface".. Seems like Interface (despite what's passed in it's place for arguments) helps eliminate other otherwise different naming conventions. Doesn't matter if you pass a Car or Ferrari or FerrariCar on your end - the argument must be a CarInterface - which makes the naming convention pretty important in my book.
I also personally use purpose driven naming for other classes CarCollection, CarPresenter, CarModel so CarInterface makes the most sense in my mind. I believe it lends to cleaner more organized code. Hopefully this makes sense ^_^ Ryan On Monday, August 15, 2016 at 2:53:26 PM UTC-5, Matthieu Napoli wrote: > > Hi all, > > This is a 2 weeks discussion before going to a vote. > > The "Interface" suffix has been questioned a few times already, I'm > suggesting we put that up to a vote and avoid future debates. Here are > relevant threads I could find on the topic: > > - https://groups.google.com/d/topic/php-fig/Zgfd0gHUUoc/discussion > - https://groups.google.com/d/topic/php-fig/dPwtKqO3Zqk/discussion > - https://groups.google.com/d/topic/php-fig/10lM-UNudvU/discussion > - https://groups.google.com/d/topic/php-fig/aBUPKfTwyHo/discussion > > Suggested change: *replace "MUST" to "MUST NOT" in "Interfaces MUST be > suffixed by Interface"* from > http://www.php-fig.org/bylaws/psr-naming-conventions/ > > I do not suggest accepted PSRs are changed. > > Please share your reasons to vote FOR or AGAINST the change, let's debate > for 2 weeks or more, and then let's have a vote to settle this. > > Discussion will last for at least 2 weeks (20:40 UTC on 29 August 2016). > > --- > > Here are my arguments to vote FOR the change: > > *- the Interface suffix makes simple names very long* > > For example with PSR-7, here is the signature of a Slim/Zend Expressive > middleware: > > public function __invoke(ServerRequestInterface $request, ResponseInterface > $response, callable $next) : ResponseInterface > > { > > } > > > Compare that to: > > public function __invoke(ServerRequest $request, Response $response, callable > $next) : Response > > { > > } > > > The last one is much simpler and clearer. Typing and reading the first one > is a huge pain. This point applies of course to all PSRs, not just PSR-7. > > *- the Interface suffix makes the interface a detail and the > implementation the main thing, it should be the other way around* > > We should care about the interface, not the implementation. Type-hinting > against LoggerInterface means that "Logger" (the implementation) is still " > *the* logger", and the interface is a secondary concept that we > explicitly inject for decoupling. > If "Logger" was the interface, it would be even more obvious that the > interface is the most important part. The implementation is secondary and I > don't even care how it's named. I just want a logger and that's what the > interface is. > > Regarding the inconsistency it would create between PSRs I think it's > nothing compared to what we would gain in terms of developer experience. > > Matthieu > -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/da47ded1-cde4-4020-9e61-ee47656ca8b6%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
