From: hexer at studentcenter dot org
Operating system: Linux
PHP version: 4.3.4
PHP Bug Type: Apache related
Bug description: mod_php4 fails Timeout setting while writing to a dead client on
Apache 1.3
Description:
------------
Problem: On Apache 1.3.x, the compiled-in mod_php4 will cause stuck httpd
processes while trying to send output from php to a dead client
connection.
The Cause: mod_php4.c does not set the Apache Timeout timer in the send
functions.
Solution: Apache recommends any modules that write to the client to use
the timeout functions provided by the Apache API.
The following modification to mod_php4.c will fix the problem and make
mod_php4 comply with Apache 1.3.x Timeout setting.
static int sapi_apache_ub_write(const char *str, uint str_length
TSRMLS_DC)
{
int ret=0;
if (SG(server_context)) {
+ ap_hard_timeout("php send body", (request_rec *)
SG(server_context));
ret = rwrite(str, str_length, (request_rec *)
SG(server_context));
+ ap_kill_timeout((request_rec *) SG(server_context));
}
if (ret != str_length) {
php_handle_aborted_connection();
}
return ret;
}
Reproduce code:
---------------
This problem is easilly reproduced by simply breaking the connection with
the server while trying to load any php-generated page.
Expected result:
----------------
Apache process must abort processing the request if a single write
operation exceeds the amount of seconds set in the Timeout setting in
httpd.conf.
Actual result:
--------------
#0 0x420d368d in writev () from /lib/i686/libc.so.6
#1 0x0815fb08 in writev_it_all ()
#2 0x0815fe77 in large_write ()
#3 0x0815ff3b in ap_bwrite ()
#4 0x08172c10 in ap_rwrite ()
#5 0x080884da in sapi_apache_ub_write ()
#6 0x0809ab6f in php_ub_body_write_no_header (
str=0x86484ec "XXXXXX"..., str_length=4144) at
/usr/local/src/php-4.3.4/main/output.c:689
#7 0x0809a117 in php_end_ob_buffer (send_buffer=1 '\001', just_flush=1
'\001')
at /usr/local/src/php-4.3.4/main/output.c:299
#8 0x0809ab39 in php_b_body_write (
str=0x8666834 "XXXXXX",
str_length=51) at /usr/local/src/php-4.3.4/main/output.c:616
#9 0x08099dd2 in php_body_write (
str=0x8666834 "XXXXXX",
str_length=51) at /usr/local/src/php-4.3.4/main/output.c:121
#10 0x080abe89 in zend_print_zval_ex (
write_func=0x808ef40 <php_body_write_wrapper>, expr=0x85992ac,
indent=0)
at /usr/local/src/php-4.3.4/Zend/zend.c:211
#11 0x080abe2f in zend_print_zval (expr=0x85992ac, indent=0)
at /usr/local/src/php-4.3.4/Zend/zend.c:192
---Type <return> to continue, or q <return> to quit---
#12 0x080abb70 in zend_print_variable (var=0x85992ac)
at /usr/local/src/php-4.3.4/Zend/zend_variables.c:147
#13 0x080b64b5 in execute (op_array=0x8642fac)
at /usr/local/src/php-4.3.4/Zend/zend_execute.c:1244
#14 0x080b8635 in execute (op_array=0x862bf24)
at /usr/local/src/php-4.3.4/Zend/zend_execute.c:2181
#15 0x080acc03 in zend_execute_scripts (type=8, retval=0x0, file_count=3)
at /usr/local/src/php-4.3.4/Zend/zend.c:884
#16 0x0808ffb3 in php_execute_script (primary_file=0xbffff650)
at /usr/local/src/php-4.3.4/main/main.c:1729
#17 0x080ba6e2 in apache_php_module_main (r=0x8256564,
display_source_mode=0)
at /usr/local/src/php-4.3.4/sapi/apache/sapi_apache.c:54
#18 0x08089038 in send_php ()
#19 0x080890a3 in send_parsed_php ()
#20 0x0816109c in ap_invoke_handler ()
#21 0x08175b1f in process_request_internal ()
#22 0x08175b7e in ap_process_request ()
#23 0x0816cd55 in child_main ()
#24 0x0816cfb6 in make_child ()
#25 0x0816d2f5 in perform_idle_server_maintenance ()
#26 0x0816d914 in standalone_main ()
#27 0x0816df1a in main ()
#28 0x420158d4 in __libc_start_main () from /lib/i686/libc.so.6
--
Edit bug report at http://bugs.php.net/?id=26494&edit=1
--
Try a CVS snapshot (php4): http://bugs.php.net/fix.php?id=26494&r=trysnapshot4
Try a CVS snapshot (php5): http://bugs.php.net/fix.php?id=26494&r=trysnapshot5
Fixed in CVS: http://bugs.php.net/fix.php?id=26494&r=fixedcvs
Fixed in release: http://bugs.php.net/fix.php?id=26494&r=alreadyfixed
Need backtrace: http://bugs.php.net/fix.php?id=26494&r=needtrace
Need Reproduce Script: http://bugs.php.net/fix.php?id=26494&r=needscript
Try newer version: http://bugs.php.net/fix.php?id=26494&r=oldversion
Not developer issue: http://bugs.php.net/fix.php?id=26494&r=support
Expected behavior: http://bugs.php.net/fix.php?id=26494&r=notwrong
Not enough info: http://bugs.php.net/fix.php?id=26494&r=notenoughinfo
Submitted twice: http://bugs.php.net/fix.php?id=26494&r=submittedtwice
register_globals: http://bugs.php.net/fix.php?id=26494&r=globals
PHP 3 support discontinued: http://bugs.php.net/fix.php?id=26494&r=php3
Daylight Savings: http://bugs.php.net/fix.php?id=26494&r=dst
IIS Stability: http://bugs.php.net/fix.php?id=26494&r=isapi
Install GNU Sed: http://bugs.php.net/fix.php?id=26494&r=gnused
Floating point limitations: http://bugs.php.net/fix.php?id=26494&r=float
