ID: 26304 Comment by: vorlon at debian dot org Reported By: vesely at tana dot it Status: Assigned Bug Type: DBM/DBA related Operating System: Solaris PHP Version: 4.3.4 Assigned To: helly New Comment:
Correction, the "bad file descriptor" error came from excessive fiddling with my test case. The lock handling when opening with mode 'c' in CVS HEAD appears to be correct for db4. Previous Comments: ------------------------------------------------------------------------ [2003-11-19 00:32:45] vorlon at debian dot org This bug has also been reported at <http://bugs.debian.org/221559>. The source of this behavior is quite clear -- ext/dba/dba.c: case 'c': modenr = DBA_CREAT; lock_mode = (lock_flag & DBA_LOCK_CREAT) ? LOCK_EX : 0; file_mode = "a+b"; if (!lock_mode || !lock_dbf) { break; } /* When we lock the db file it will be created before the handler * even tries to open it, hence we must change to truncate mode. */ case 'n': modenr = DBA_TRUNC; lock_mode = (lock_flag & DBA_LOCK_TRUNC) ? LOCK_EX : 0; file_mode = "w+b"; break; So unless locking is explicitly disabled (or explicitly configured to use an external lockfile), 'CREAT' mode results in automatic truncation of the database? What kind of sense does that make? The behavior on the HEAD branch looks correct, but doesn't seem to interact well with the 4.3 version of the code ("Driver initialization failed for handler: db4: Bad file descriptor"). The current behavior certainly is NOT correct, for db4. ------------------------------------------------------------------------ [2003-11-18 12:59:58] vesely at tana dot it Also, that correction around line 67 in dba_db4.c (DBA_OPEN_FUNC) is bogus: if stat returns 0 you want to say DB_UNKNOWN, since you cannot say it is DB_BTREE when it was created by some other program. To reproduce the bug you should create a DB with a different type, e.g. in C if you just include db.h and then call the dbm_open compatibility layer. The Sleepycat message will then say "call implies an access method which is inconsistent with previous calls." ------------------------------------------------------------------------ [2003-11-18 12:09:46] vesely at tana dot it Description: ------------ Opening a file in 'c' mode (see example below) truncates the file!! The docs say '"c" for read/write access and database creation if it doesn't currently exist.' I cannot understand that comment at line 658 in ext/dba/dba.c, as it seems to imply that truncating the database is necessary for locking it (??). Reproduce code: --------------- dba_open("important_data.db", "c", "db4"); Expected result: ---------------- open db (create if doesn't exist) Actual result: -------------- truncated db ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=26304&edit=1
