Edit report at https://bugs.php.net/bug.php?id=63004&edit=1
ID: 63004
Updated by: ni...@php.net
Reported by: juzna dot cz at gmail dot com
Summary: errors json_encode do NOT call error handler
Status: Not a bug
Type: Bug
Package: JSON related
Operating System: Ubuntu 10.04
PHP Version: 5.4.6
Block user comment: N
Private report: N
New Comment:
By the way, in PHP 5.5 the behavior here changes and there is no warning at
all. The error will be available via json_last_error() and a second function
which returns a human readable string instead of an error code.
Previous Comments:
------------------------------------------------------------------------
[2012-09-04 03:28:46] ras...@php.net
It isn't a new mechanism for PHP. We have had things like mysql_error(),
socket_last_error(), oci_error(), ldap_error(), pg_last_error(),
libxml_get_errors(), preg_last_error(), curl_error() and many money for a very
long time.
The main reason to not surface a warning here is that the only way to avoid it
would be to call iconv('utf-8','utf-8',$str) on all strings to be encoded. This
is a huge hassle to do, it is slow, and this is something we actually do
internally in json_encode() to validate utf-8 anyway, so it would be entirely
redundant. And since in many cases you end up passing user data or at least 3rd-
party data directly to json_encode() you would have to always add this
redundant
check.
------------------------------------------------------------------------
[2012-09-04 03:17:44] david at grudl dot com
This is the only one function in whole PHP with this behaviour. So is it a new
way of error handling or bug?
------------------------------------------------------------------------
[2012-09-03 23:36:20] ras...@php.net
json_encode() now checks for valid utf-8. It makes no sense to generate
warnings
for core functionality of the function. You can check json_last_error() for
JSON_ERROR_UTF8 if you want to programmatically catch invalid utf-8.
------------------------------------------------------------------------
[2012-09-03 22:15:55] juzna dot cz at gmail dot com
Actually, a similar bug (52397) has been known for more than 2 years. In latest
snapshot of PHP 5.4 it just got worse :/
------------------------------------------------------------------------
[2012-09-03 22:14:16] juzna dot cz at gmail dot com
Description:
------------
When there is an error within json_encode (e.g. due to invalid utf8), E_WARNING
should be raised. However, that doesn't happen in some cases.
It doesn't happen when display_errors is set to On.
In latest snapshot of 5.4 it does not happen at all.
Test script:
---------------
<?php
/**
* WTF? Error handler is not called, when display_errors=On
*
* _errorHandler must be called in each case, but it's not.
*
* Results differ on different PHP versions.
*/
function _errorHandler($severity, $message, $file, $line, $context) {
$GLOBALS['err'] = func_get_args();
// echo "Error ($severity) $message in $file:$line\n";
}
set_error_handler('_errorHandler');
// display_errors = Off, works fine
{
ini_set('display_errors', 0);
// Calls error handler, fine
$err = NULL;
$tmp = substr(new stdClass(), 1, 1);
var_dump($err[0], $err[1]);
// Calls error handler, fine
$err = NULL;
$tmp = json_encode(array("bad utf\xFF"));
var_dump($err[0], $err[1]);
}
// display_errors = On, WTF???
{
ini_set('display_errors', 1);
// Calls error handler, fine
$err = NULL;
$tmp = substr(new stdClass(), 1, 1);
var_dump($err[0], $err[1]);
// Does NOT call error handler, WTF???
$err = NULL;
$tmp = json_encode(array("bad utf\xFF"));
var_dump($err[0], $err[1]);
}
Expected result:
----------------
int(2)
string(55) "substr() expects parameter 1 to be string, object given"
int(2)
string(49) "json_encode(): Invalid UTF-8 sequence in argument"
int(2)
string(55) "substr() expects parameter 1 to be string, object given"
int(2)
string(49) "json_encode(): Invalid UTF-8 sequence in argument"
Actual result:
--------------
On 5.4.6:
int(2)
string(55) "substr() expects parameter 1 to be string, object given"
int(2)
string(49) "json_encode(): Invalid UTF-8 sequence in argument"
int(2)
string(55) "substr() expects parameter 1 to be string, object given"
NULL
NULL
On 5.4-latest:
int(2)
string(55) "substr() expects parameter 1 to be string, object given"
NULL
NULL
int(2)
string(55) "substr() expects parameter 1 to be string, object given"
NULL
NULL
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=63004&edit=1
