Edit report at https://bugs.php.net/bug.php?id=61602&edit=1
ID: 61602
Comment by: sebast...@php.net
Reported by: sebast...@php.net
Summary: Allow access to name of constant used as default
value
Status: Open
Type: Feature/Change Request
Package: Reflection related
Operating System: Irrelevant
PHP Version: 5.4Git-2012-04-02 (Git)
Block user comment: N
Private report: N
New Comment:
Can we at least merge the patch into master? Once it's there we can think about
merging it into PHP 5.4 for PHP 5.4.2.
Previous Comments:
------------------------------------------------------------------------
[2012-04-08 00:45:21] s...@php.net
Not very likely for 5.4.1, doesn't seem to be a critical bug. For 5.4.2, maybe.
------------------------------------------------------------------------
[2012-04-03 09:22:42] sebast...@php.net
Any chance this pull request will be merged into PHP 5.4.1? Thanks.
------------------------------------------------------------------------
[2012-04-03 06:07:04] reeze dot xia at gmail dot com
PS:
@pierrick pull request is here https://github.com/php/php-src/pull/35.
thanks.
------------------------------------------------------------------------
[2012-04-03 05:56:12] reeze dot xia at gmail dot com
Hi, pierrick & sebastian:
I have create another patch for this request. it differ's in:
- rename defaultValueIsConstant to isDefaultValueConstant to match bool
return values's is* method naming.
- handle global constant.
- refactor code to remove duplicate.
- add 3 tests for it.
and I've make test everything looks fine.
please review it for me.
Thanks.
------------------------------------------------------------------------
[2012-04-03 00:24:13] pierr...@php.net
Just created a quick patch. If it's Ok with everybody I'll commit it to master
with tests.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=61602
--
Edit this bug report at https://bugs.php.net/bug.php?id=61602&edit=1
