Edit report at https://bugs.php.net/bug.php?id=61272&edit=1

 ID:                 61272
 User updated by:    peacech at gmail dot com
 Reported by:        peacech at gmail dot com
 Summary:            ob_start callback get passed empty string
 Status:             Not a bug
 Type:               Bug
 Package:            Output Control
 Operating System:   Arch 32 bit
 PHP Version:        5.4.0
 Block user comment: N
 Private report:     N

 New Comment:

Unless ob_start callback specification has changed that for 
ob_clean/ob_end_clean, the output is discarded before calling the callback, 
then this is a bug. And I have scan the PHP 5.4 changelog and couldn't find 
anything mentioning this change.

So let me help by showing where the problem is

In line 1226 of output.c in the distributed PHP 5.4.0 source,

if (flags & PHP_OUTPUT_POP_DISCARD) {
    context.op |= PHP_OUTPUT_HANDLER_CLEAN;
    orphan->buffer.used = 0;
}
php_output_handler_op(orphan, &context);

orphan->buffer.used should not be set to 0 before calling the callback, 
otherwise the callback will be called with empty buffer.

And likewise in line 300 in php_output_clean

So, no, it isn't about appending $output to $buffer.


Previous Comments:
------------------------------------------------------------------------
[2012-03-05 11:23:43] m...@php.net

Sorry, but your problem does not imply a bug in PHP itself.  For a
list of more appropriate places to ask for help using PHP, please
visit http://www.php.net/support.php as this bug system is not the
appropriate forum for asking support questions.  Due to the volume
of reports we can not explain in detail here why your report is not
a bug.  The support channels will be able to provide an explanation
for you.

Thank you for your interest in PHP.

You should append $output to $buffer.

------------------------------------------------------------------------
[2012-03-04 10:53:53] peacech at gmail dot com

Description:
------------
Running test script below with PHP 5.4 outputs

""

Running test script below with PHP 5.3 outputs

"hello"

Test script:
---------------
<?php

$buffer = -1;
function callback($output)
{
        global $buffer;
        $buffer = $output;
        return $output;
}

ob_start('callback');
echo 'hello';
ob_get_clean();

var_dump($buffer);

Expected result:
----------------
"hello"

Actual result:
--------------
""


------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=61272&edit=1

Reply via email to