Edit report at https://bugs.php.net/bug.php?id=60919&edit=1

 ID:                 60919
 Updated by:         paj...@php.net
 Reported by:        the...@php.net
 Summary:            __wakeup is not called
-Status:             Duplicate
+Status:             Feedback
 Type:               Bug
 Package:            Scripting Engine problem
 Operating System:   (Any)
 PHP Version:        5.4.0RC6+
-Assigned To:        pajoye
+Assigned To:        stas
 Block user comment: N
 Private report:     N

 New Comment:

Actually maybe still valid on other platform than windows, but so far our tests 
on 
linux (x86&x64) did not show any issue with this issue.

Timm, which platforms exactly do you use to test? The other bug I referred to 
(#60879) is a windows only bug and only due to the release build process, not 
to a 
bug in our code base.


Previous Comments:
------------------------------------------------------------------------
[2012-02-20 10:48:47] paj...@php.net

Duplicate of #60879

------------------------------------------------------------------------
[2012-02-05 18:02:48] the...@php.net

Stas, can you have a look at the patch? Thanks!

------------------------------------------------------------------------
[2012-02-05 16:28:20] ras...@php.net

You should ask Stas for permission to commit this patch to 5.4 before the 
release. Initializing uninitialized variables tends to be a good idea.

------------------------------------------------------------------------
[2012-02-05 14:03:53] the...@php.net

The following patch has been added/updated:

Patch Name: init-serialize-levels.diff
Revision:   1328450632
URL:        
https://bugs.php.net/patch-display.php?bug=60919&patch=init-serialize-levels.diff&revision=1328450632

------------------------------------------------------------------------
[2012-02-05 14:00:32] the...@php.net

I can also not reproduce the issue if I compile PHP myself, neither on Linux 
nor on Windows.

>From looking at the diffs between 5.4.0RC5 and current SVN, BG(serialize_lock) 
>in conjunction with BG(unserialize).level and BG(serialize).level) sticks out. 
>The thing I think is suspicous here is that BG(unserialize).level gets 
>assigned to 1 inside a block guarded by if (... || !BG(unserialize).level) {, 
>but is never assigned to 0. 

Are we running into this problem because BG(unserialize).level doesn't properly 
get initialized? I'm not an expert here but is it safe to rely on the compiler 
doing thos?

Same goes for BG(serialize).level, by the way.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=60919


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=60919&edit=1

Reply via email to