Edit report at https://bugs.php.net/bug.php?id=52078&edit=1
ID: 52078
Comment by: tyr...@php.net
Reported by: glen at delfi dot ee
Summary: fileinode overflow test
ext/standard/tests/file/fileinode_variation3.phpt
Status: Assigned
Type: Bug
Package: Filesystem function related
Operating System: PLD Linux
PHP Version: 5.3.2
Assigned To: tyrael
Block user comment: N
Private report: N
New Comment:
I would prefer the a (%i) solution, there is no reason to skip tests (and miss
regression) on 32bit only because the values (whom excat values we don't really
care) can overflow on some configurations.
Previous Comments:
------------------------------------------------------------------------
[2012-02-06 23:51:23] glen at delfi dot ee
i could supply the patches, if i get answer WHICH WAY TO GO!
a) %i in formats like in initial patch?
b) PHP_INT_SIZE check, like asked in comment #3?
c) something else???
------------------------------------------------------------------------
[2012-02-06 22:50:44] tyr...@php.net
applied the original patch to the 5.4 branch also.
if you can come up with patches for the other tests I can also apply then soon,
if
not I will try to go through the affected tests, but that will take longer.
------------------------------------------------------------------------
[2012-02-06 22:47:22] tyr...@php.net
Automatic comment from SVN on behalf of tyrael
Revision: http://svn.php.net/viewvc/?view=revision&revision=323100
Log: merging the patch from bug #52078, fixes the test on disk with huge inode
size(fileinode() can overflow and return negative values there).
------------------------------------------------------------------------
[2012-01-20 23:56:28] glen at delfi dot ee
please note that the patch provided in bug was not complete (there are more
tests
suffering the same deficiency), because did not get any feedback to decide to
proceed further.
"find -name '*.phpt' | xargs grep fileinode" in source tree should give ideas
what more to patch (and of course all inode related functions: getmyinode,
stat,
...)
------------------------------------------------------------------------
[2012-01-19 19:09:44] tyr...@php.net
I commited the %d->%i changes to trunk and 5.3, waiting for approval to commit
it
to 5.4 as well, I will keep the ticket open until.
http://svn.php.net/viewvc?view=revision&revision=322460
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=52078
--
Edit this bug report at https://bugs.php.net/bug.php?id=52078&edit=1
