Edit report at http://bugs.php.net/bug.php?id=53198&edit=1
ID: 53198
Updated by: cataphr...@php.net
Reported by: RQuadling at GMail dot com
Summary: "From:" header sent on http request when using
stream_context.
-Status: Assigned
+Status: Closed
Type: Bug
Package: Streams related
Operating System: Windows XP SP3
PHP Version: 5.3SVN-2010-10-29 (SVN)
Assigned To: cataphract
Block user comment: N
New Comment:
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
Thank you for the report, and for helping us make PHP better.
Previous Comments:
------------------------------------------------------------------------
[2010-10-29 17:37:57] cataphr...@php.net
Automatic comment from SVN on behalf of cataphract
Revision: http://svn.php.net/viewvc/?view=revision&revision=304986
Log: - Documented that the INI setting "from" is used to
populate the From
header in connections with the http wrapper.
- Addresses bug #53198.
------------------------------------------------------------------------
[2010-10-29 17:29:17] cataphr...@php.net
Automatic comment from SVN on behalf of cataphract
Revision: http://svn.php.net/viewvc/?view=revision&revision=304985
Log: - Fixed bug #53198 (changing INI setting "from" with
ini_set did not have any
effect)
#Made "from" a proper INI setting and bound it to a global
variable.
#Previously, it was simply read from the hash table with the parsed ini
file
#by using cfg_get_string (I wonder why this mechanism still exists...)
------------------------------------------------------------------------
[2010-10-29 10:24:21] RQuadling at GMail dot com
Using ini_set('from', 'j...@junk.com'); has no effect on the output in
WireShark.
Using ...
<?php
ini_set('from', 'no...@home.com');
file_get_contents(
'http://www.php.net/Test1',
False,
...
shows
GET /Test1 HTTP/1.0
From: automatecta...@bandvulc.co.uk
Host: www.php.net
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US)
AppleWebKit/534.10
(KHTML, like Gecko) Chrome/8.0.552.18 Safari/534.10
and the response includes ...
Location: http://uk3.php.net/Test1
and that request also includes the From: header.
So, if 'from' is kept as an option, the documentation is out as it is
not a
PHP_INI_ALL entry.
------------------------------------------------------------------------
[2010-10-29 10:16:18] RQuadling at GMail dot com
This feature was introduced in http://svn.php.net/viewvc/php/php-
src/trunk/ext/standard/http_fopen_wrapper.c?annotate=73428&pathrev=73428#l159,
which is over 8 years ago.
This may not be a code bug but a documentation issue.
Personally, a 'From:' header for a normal HTTP request seems
inappropriate. For
anonymouse FTP, then maybe/probably.
Attached is a patch to remove the setting from 5.3 and trunk.
------------------------------------------------------------------------
[2010-10-29 09:52:30] RQuadling at GMail dot com
Description:
------------
When using a stream_context, the "From:" header is added to the request,
even
though the "From:" header is documented to be used for anonymous FTP
requests.
I don't know how to read the headers being SENT when using a
stream_context, so I
had to use WireShark. The results below relate to the output of
WireShark.
Test script:
---------------
<?php
file_get_contents(
'http://www.php.net',
False,
stream_context_create(
array(
'http' => array(
'method' => 'GET',
'header' => "User-Agent: Mozilla/5.0 (Windows;
U; Windows NT 5.1;
en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.18
Safari/534.10\r\n",
)
)
)
);
Expected result:
----------------
GET / HTTP/1.0
Host: www.php.net
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US)
AppleWebKit/534.10
(KHTML, like Gecko) Chrome/8.0.552.18 Safari/534.10
Actual result:
--------------
GET / HTTP/1.0
From: automatecta...@[edited]
Host: www.php.net
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US)
AppleWebKit/534.10
(KHTML, like Gecko) Chrome/8.0.552.18 Safari/534.10
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/bug.php?id=53198&edit=1
