Edit report at http://bugs.php.net/bug.php?id=52098&edit=1
ID: 52098 Updated by: fel...@php.net Reported by: jpa...@php.net Summary: Own PDOStatement implementation ignore __call() Status: Open Type: Bug Package: PDO related Operating System: *nix & Win PHP Version: 5.3.2 New Comment: I've committed a fix for the crash: http://svn.php.net/viewvc?view=revision&revision=300503 Previous Comments: ------------------------------------------------------------------------ [2010-06-17 01:09:56] fel...@php.net I can reproduce it with another test case: <?php class MyStatement extends PDOStatement { } $obj = new MyStatement; var_dump($obj->foo()); Adding the support to __call lead to a strange behavior for classes that inherits PDOStatement. As it must be check if the called method is a user method or an driver method (which isn't stored in function_table) - that's when the instance is created by PDO object. If we introduce __call check, it must be done after the driver method checking... which will behave diferently when the instance is created by PDO or not... ------------------------------------------------------------------------ [2010-06-17 00:20:50] fel...@php.net I cannot reproduce the segmentation fault. ------------------------------------------------------------------------ [2010-06-16 17:12:27] jpa...@php.net Description: ------------ When using an own PDOStatement implementation, __call() is simply ignored in it. *Additionally* it may lead to segfaults if the Statement object is user constructed. The problem is in pdo_stmt.c _zend_function *dbstmt_method_get(){ : if (zend_hash_find(&Z_OBJCE_P(object)->function_table, lc_method_name, method_len+1, (void**)&fbc) == FAILURE) { pdo_stmt_t *stmt = (pdo_stmt_t*)zend_object_store_get_object(object TSRMLS_CC); if (!stmt->dbh->cls_methods[PDO_DBH_DRIVER_METHOD_KIND_STMT]) { [...] stmt is not initialized properly when it comes back from the object store. I didn't search deeper from that point. The bug has already been reported and marked as fixed (46396), but it doesn't seem to have been fixed. Test script: --------------- <?php class MyStatement extends PDOStatement { public function __call($meth, $args) { return "$meth called"; } } $p = new PDO('sqlite::memory:'); $p->setAttribute(PDO::ATTR_STATEMENT_CLASS, array('MyStatement')); $r = $p->query('SELECT 123'); echo $r->foo(); // (1) $obj = new MyStatement; echo $obj->foo(); // (2) Expected result: ---------------- foo called (1) foo called (2) Actual result: -------------- Fatal error: Call to undefined method MyStatement::foo() in XXXX (1) Segmentation Fault (2) ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/bug.php?id=52098&edit=1
