ID:               49464
 Updated by:       paj...@php.net
 Reported By:      raulsalitrero at gmail dot com
-Status:           Open
+Status:           Closed
 Bug Type:         Compile Failure
 Operating System: win32 only - Windows Xp SP3
 PHP Version:      5.3SVN-2009-09-04 (SVN)
-Assigned To:      
+Assigned To:      pajoye
 New Comment:

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------

[2009-09-04 19:53:39] s...@php.net

Automatic comment from SVN on behalf of pajoye
Revision: http://svn.php.net/viewvc/?view=revision&revision=288067
Log: - #49464, fix build

------------------------------------------------------------------------

[2009-09-04 15:50:46] raulsalitrero at gmail dot com

i've just tried it, it works now.
thanks.

------------------------------------------------------------------------

[2009-09-04 10:26:14] ka...@php.net

The fix for this is pretty simple:
http://pastie.org/605649

However this C2491 only occurs when building sockets shared because of
the wrong exporting declarings used

------------------------------------------------------------------------

[2009-09-04 03:44:59] raulsalitrero at gmail dot com

Description:
------------
php_sockets.dll build is broken in win vc9, with the next error

ext\sockets\sockets.c(327) : error C2491: 'php_sockets_le_socket' :
definition of dllimport function not allowed

tried building the last svn source with the same result.

using vc9 to compile, the error is also observable in the windows
sanpshots compile logs 

the bug was introduced in revision: 287911 - export le_socket from
ext/sockets
changing files:
-/php/php-src/branches/PHP_5_3/ext/sockets/php_sockets.h
-/php/php-src/branches/PHP_5_3/ext/sockets/sockets.c

Reproduce code:
---------------
use nmake to compile with vc9 compiler

Expected result:
----------------
php_sockets.dll is built

Actual result:
--------------
php_sockets.dll is missing from the result build


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=49464&edit=1

Reply via email to