ID: 48182 Comment by: sriram dot natarajan at gmail dot com Reported By: frase at cs dot wisc dot edu Status: Open Bug Type: Sockets related Operating System: * PHP Version: 5.2.10, 5.3.0 New Comment:
better still, here is the patch (more readable format) http://pastebin.org/805 Previous Comments: ------------------------------------------------------------------------ [2009-07-09 21:47:44] sriram dot natarajan at gmail dot com thanks for your patience. here is a patch that should address your issue. to apply this patch, save the above text into a file and run --- ext/openssl/xp_ssl.c.ORIG Thu Jul 9 12:20:44 2009 +++ ext/openssl/xp_ssl.c Thu Jul 9 12:29:18 2009 @@ -672,7 +672,11 @@ * we notice that the connect has actually been established */ php_stream_socket_ops.set_option(stream, option, value, ptrparam TSRMLS_CC); - if (xparam->outputs.returncode == 0 && sslsock->enable_on_connect) { + if ((sslsock->enable_on_connect) && + ((xparam->outputs.returncode == 0) || + (xparam->op == STREAM_XPORT_OP_CONNECT_ASYNC && xparam->outputs.returncode == 1 && + xparam->outputs.error_code == EINPROGRESS))) + { if (php_stream_xport_crypto_setup(stream, sslsock->method, NULL TSRMLS_CC) < 0 || php_stream_xport_crypto_enable(stream, 1 TSRMLS_CC) < 0) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to enable crypto"); - download and unzip the latest php 5.3snapshot from http://snaps.php.net - cd <php-workspace> ; patch -p0 -d . < <filename> now, you can run make and should be able to test it. i will wait for some one to review this patch . hopefully, should happen before next release :-) ------------------------------------------------------------------------ [2009-07-01 16:28:14] frase at cs dot wisc dot edu This bug remains also in 5.2.10. Let's try a new summary and changing the category to "Sockets", maybe it will get someone's attention. ------------------------------------------------------------------------ [2009-06-30 14:28:01] frase at cs dot wisc dot edu This bug remains in 5.3.0 final. ------------------------------------------------------------------------ [2009-06-19 13:38:53] frase at cs dot wisc dot edu This bug is still present in 5.3.0 as of RC4, and also affects Linux hosts. ------------------------------------------------------------------------ [2009-06-08 14:14:30] frase at cs dot wisc dot edu Hate to bump my own bug, but it's been a month. Nobody's concerned that ssl:// streams + ASYNC_CONNECT has this silent failure? And that there's a chance it's causing data intended for ssl:// to instead be transmitted in plaintext? ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/48182 -- Edit this bug report at http://bugs.php.net/?id=48182&edit=1
