ID: 45456 Updated by: [EMAIL PROTECTED] Reported By: Keisial at gmail dot com -Status: Assigned +Status: Closed Bug Type: Compile Warning Operating System: Windows PHP Version: 5.3CVS-2008-07-08 (snap) Assigned To: pajoye New Comment:
This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Last _WIN32_WINNT redefs are now gone and is committed to both PHP_5_3 and HEAD Previous Comments: ------------------------------------------------------------------------ [2008-07-13 00:01:12] [EMAIL PROTECTED] The patch here: http://news.php.net/php.internals.win/45 fixes this problem, should be committed soon. ------------------------------------------------------------------------ [2008-07-08 14:40:24] [EMAIL PROTECTED] Pierre, you're working on Windows stuff these days, please have a look, thanks. ------------------------------------------------------------------------ [2008-07-08 13:46:19] Keisial at gmail dot com Description: ------------ _WIN32_WINNT macro can be defiend before including windows headers to specify the minimun windows nt version to support (usually to unhide prototypes not available on previous versions). It is used like this on TSRM/readdir.h before including windows.h So far, so good. However, due to include order, windows.h is already included before, defining _WIN32_WINNT by itself and thus it doesn't do anything. So the define should either be removed (if it's not needed), or moved before. Reproduce code: --------------- _WIN32_WINNT is defined on TSRM/readdir.h:10: main/php.h:405->TSRM/tsrm_virtual_cwd.h:55->readdir.h windows.h was already included by: main/php.h:34->Zend/zend.h:53->zend_config.w32.h:39 (in fact winsock2.h at zend_config.w32.h:38 is already including it before the real one) ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=45456&edit=1
