On 13.02.25 12:38, Vladlen Popolitov wrote:
Vladlen Popolitov писал(а) 2025-02-13 17:58:
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: tested, failed
Hi!
Previous email has text "failed". It is generated by "send review"
function,
I do not know, how to change it (tried in other browsers).
Nothing failed in this patch.
This patch is pretty old but it was still hanging around as open in the
commitfest app.
I realize that the way the PostgreSQL build process finds all the
dependencies is pretty complicated right now. With configure some of
them are found the old way using CPPFLAGS/LDFLAGS, some via specific
foo-config scripts, some via pkg-config, some via specific custom code.
With meson, similarly, but the actual details are different in each
case. Maybe we should document all of this accurately, or maybe it
would be unmaintainable. In any case, I don't think your patch has
enough coverage to make this better, it just describes some specific
scenario that works for you, and it moves some text out of context where
it doesn't make sense anymore. Maybe this kind of information is better
in a how-to document or blog post, and from there we could generalize
the information and maybe feed it back into the documentation.
