From 08c90997b682d88d59d6481ea00542108b867a59 Mon Sep 17 00:00:00 2001 From: Amit Langote Date: Fri, 27 Mar 2026 14:33:35 +0900 Subject: [PATCH v3] Add comment explaining fire_triggers=false in ri_PerformCheck() The reason for passing fire_triggers=false to SPI_execute_snapshot() in ri_PerformCheck() was not documented, making it unclear why it was done that way. Add a comment explaining that it ensures AFTER triggers are queued in the outer query's after-trigger context and fire only after all RI updates on the same row are complete. Author: Yugo Nagata Reviewed-by: Kirill Reshke Reviewed-by: Surya Poondla Discussion: https://postgr.es/m/20250331212648.ad4ab804559001d7f0788741@sraoss.co.jp --- src/backend/utils/adt/ri_triggers.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/backend/utils/adt/ri_triggers.c b/src/backend/utils/adt/ri_triggers.c index d22b8ef7f3c..6230a2ea9ad 100644 --- a/src/backend/utils/adt/ri_triggers.c +++ b/src/backend/utils/adt/ri_triggers.c @@ -2582,7 +2582,13 @@ ri_PerformCheck(const RI_ConstraintInfo *riinfo, save_sec_context | SECURITY_LOCAL_USERID_CHANGE | SECURITY_NOFORCE_RLS); - /* Finally we can run the query. */ + /* + * Finally we can run the query. + * + * Set fire_triggers to false to ensure that AFTER triggers are queued in + * the outer query's after-trigger context and fire after all RI updates + * on the same row are complete, rather than immediately. + */ spi_result = SPI_execute_snapshot(qplan, vals, nulls, test_snapshot, crosscheck_snapshot, -- 2.47.3