Dear Sergey, Sorry for being late, I was busy in another project. Not sure we have enough time to rush this for PG19 because some new parts are added recently.
Personally considered, the patch might be able to separate into two parts. 0001 contains changes to migrate the replication origin, and 0002 contains to migrate the commit_ts directory. For 0001, we may need a new SQL function to migrate replication origins, and it could be used only while in the binary upgrade mode like binary_upgrade_add_sub_rel_state(). We must not directly update the system catalog via UPDATE command. 0002 might be the same as what we discussed earlier. > 1. Added the --pg-commit-ts command line key for pg_upgrade. > Migration of the pg_commit_ts directory will be performed only if the user > explicitly wishes. I cannot find the reason why you changed here. Can you share me your opinion? Best regards, Hayato Kuroda FUJITSU LIMITED
