On Tue, Mar 24, 2026 at 9:02 PM Ashutosh Bapat <[email protected]> wrote: > > > I will continue from 0008 tomorrow. >
I reviewed the documentation part of 0008. I have a few edits attached. I have just one comment that's not covered in the edits @@ -4254,8 +4254,8 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx <para> Anonymous allocations are allocations that have been made with <literal>ShmemAlloc()</literal> directly, rather than via - <literal>ShmemInitStruct()</literal> or - <literal>ShmemInitHash()</literal>. + <literal>ShmemRequestStruct()</literal> or + <literal>ShmemRequestHash()</literal>. </para> ShmemInitStruct() and ShmemInitHash() are still the functions to allocate named structures. If we are going to keep ShmemInitStruct() and ShmemInitHash() around for a while, I think it is more accurate to mention them in this sentence along with the new functions. Will continue reviewing the patch tomorrow. -- Best Wishes, Ashutosh Bapat
0008_edits.patch.nocibot
Description: Binary data
