> On Mar 24, 2026, at 05:21, Zsolt Parragi <[email protected]> wrote:
>
> This is definitely a nice improvement, I only have two minor questions:
>
> - errmsg("internal error in OAuth validator module"));
> + errmsg("internal error in OAuth validator module"),
> + ret->error_detail ? errdetail_log("%s", ret->error_detail) : 0);
> +
>
> Isn't including the detail for both the warning and the fatal error
> still overly verbose?
>
I have the same feeling. If the detail has already been printed together with
the WARNING, then maybe there is no longer much need to pass it out through
logdetail.
I also have a small comment on the doc change. The documentation already
mentions the memory requirements for error_detail, so I wonder if it also makes
sense to mention its style. Since it is emitted as a DETAIL message, I think it
should probably follow the usual style rules for detail messages, i.e., start
with a capital letter and end with a period.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
