Dear Amit, > > This looks odd to me. I think it would be better to encapsulate this > in one function (something like we have in pg_log_v) and then based on > log level, do required handling. >
Based on the suggestion, I updated patches. Please see attached series. v11-0001 replaces existing pg_log_xxx families to new reporting function pg_createsub_log(). Now only pg_fatal is overwritten, which is same as pg_uprade. v11-0002 is the rebased version of v10. Nothing new, but codes are adjusted based on 0001. v11-0003 contains changes from me [1]. 0002 and 0003 can be combined if it's OK. [1]: https://www.postgresql.org/message-id/OS9PR01MB12149C7DE09F13C3BCBD9357DF54EA%40OS9PR01MB12149.jpnprd01.prod.outlook.com Best regards, Hayato Kuroda FUJITSU LIMITED
v11-0001-pg_createsubscriber-use-own-reporting-functions.patch
Description: v11-0001-pg_createsubscriber-use-own-reporting-functions.patch
v11-0002-Add-a-new-argument-l-logdir-to-pg_createsubscrib.patch
Description: v11-0002-Add-a-new-argument-l-logdir-to-pg_createsubscrib.patch
v11-0003-Address-comments-from-Hayato-Kuroda.patch
Description: v11-0003-Address-comments-from-Hayato-Kuroda.patch
