On Wed, Mar 18, 2026 at 07:35:47AM +0000, David Steele wrote: > You are correct -- the copy of pg_control needs to happen before > do_pg_backup_stop(). An older version of this patch saved pg_control in > backup_state which made the prior location safe. However, I missed moving > this code when I moved pg_control out of backup_state. Code review to the > rescue.
Right. I am wondering also if the final result would not be better without 0002, actually, focusing only on the "simpler" base backup case through the replication protocol, and you are making a good case in mentioning it as not absolutely mandatory for base backups that are taken through the SQL functions. One could always tweak the flag manually in the control file based on the contents taken from the data folder. That's more hairy than writing the entire file, for sure, still possible. -- Michael
signature.asc
Description: PGP signature
