From d6d5a31a8d1d6d2bf25ffd79bb351206da64bf2a Mon Sep 17 00:00:00 2001 From: Shlok Kyal Date: Wed, 3 Dec 2025 14:27:51 +0530 Subject: [PATCH v1] Rename column slotsync_skip_at to slotsync_last_skip This patch renames column slotsync_skip_at of view pg_stat_replication_slots to slotsync_last_skip to make it consistent with similar columns names. --- contrib/test_decoding/expected/stats.out | 12 ++++++------ doc/src/sgml/monitoring.sgml | 2 +- src/backend/catalog/system_views.sql | 2 +- src/backend/utils/activity/pgstat_replslot.c | 2 +- src/backend/utils/adt/pgstatfuncs.c | 6 +++--- src/include/catalog/pg_proc.dat | 2 +- src/include/pgstat.h | 2 +- src/test/regress/expected/rules.out | 4 ++-- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/contrib/test_decoding/expected/stats.out b/contrib/test_decoding/expected/stats.out index e5117f88a14..a9ead3c41aa 100644 --- a/contrib/test_decoding/expected/stats.out +++ b/contrib/test_decoding/expected/stats.out @@ -78,17 +78,17 @@ SELECT slot_name, spill_txns = 0 AS spill_txns, spill_count = 0 AS spill_count, -- verify accessing/resetting stats for non-existent slot does something reasonable SELECT * FROM pg_stat_get_replication_slot('do-not-exist'); - slot_name | spill_txns | spill_count | spill_bytes | stream_txns | stream_count | stream_bytes | mem_exceeded_count | total_txns | total_bytes | slotsync_skip_count | slotsync_skip_at | stats_reset ---------------+------------+-------------+-------------+-------------+--------------+--------------+--------------------+------------+-------------+---------------------+------------------+------------- - do-not-exist | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | + slot_name | spill_txns | spill_count | spill_bytes | stream_txns | stream_count | stream_bytes | mem_exceeded_count | total_txns | total_bytes | slotsync_skip_count | slotsync_last_skip | stats_reset +--------------+------------+-------------+-------------+-------------+--------------+--------------+--------------------+------------+-------------+---------------------+--------------------+------------- + do-not-exist | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | (1 row) SELECT pg_stat_reset_replication_slot('do-not-exist'); ERROR: replication slot "do-not-exist" does not exist SELECT * FROM pg_stat_get_replication_slot('do-not-exist'); - slot_name | spill_txns | spill_count | spill_bytes | stream_txns | stream_count | stream_bytes | mem_exceeded_count | total_txns | total_bytes | slotsync_skip_count | slotsync_skip_at | stats_reset ---------------+------------+-------------+-------------+-------------+--------------+--------------+--------------------+------------+-------------+---------------------+------------------+------------- - do-not-exist | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | + slot_name | spill_txns | spill_count | spill_bytes | stream_txns | stream_count | stream_bytes | mem_exceeded_count | total_txns | total_bytes | slotsync_skip_count | slotsync_last_skip | stats_reset +--------------+------------+-------------+-------------+-------------+--------------+--------------+--------------------+------------+-------------+---------------------+--------------------+------------- + do-not-exist | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | (1 row) -- spilling the xact diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 039d73691be..d2dd5e28365 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -1671,7 +1671,7 @@ description | Waiting for a newly initialized WAL file to reach durable storage - slotsync_skip_attimestamp with time zone + slotsync_last_skiptimestamp with time zone Time at which last slot synchronization was skipped. Slot diff --git a/src/backend/catalog/system_views.sql b/src/backend/catalog/system_views.sql index 086c4c8fb6f..48af8ee90a6 100644 --- a/src/backend/catalog/system_views.sql +++ b/src/backend/catalog/system_views.sql @@ -1078,7 +1078,7 @@ CREATE VIEW pg_stat_replication_slots AS s.total_txns, s.total_bytes, s.slotsync_skip_count, - s.slotsync_skip_at, + s.slotsync_last_skip, s.stats_reset FROM pg_replication_slots as r, LATERAL pg_stat_get_replication_slot(slot_name) as s diff --git a/src/backend/utils/activity/pgstat_replslot.c b/src/backend/utils/activity/pgstat_replslot.c index e08d33e8b4c..d757e00eb54 100644 --- a/src/backend/utils/activity/pgstat_replslot.c +++ b/src/backend/utils/activity/pgstat_replslot.c @@ -127,7 +127,7 @@ pgstat_report_replslotsync(ReplicationSlot *slot) statent = &shstatent->stats; statent->slotsync_skip_count += 1; - statent->slotsync_skip_at = GetCurrentTimestamp(); + statent->slotsync_last_skip = GetCurrentTimestamp(); pgstat_unlock_entry(entry_ref); } diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index 7e2ed69138a..ef6fffe60b9 100644 --- a/src/backend/utils/adt/pgstatfuncs.c +++ b/src/backend/utils/adt/pgstatfuncs.c @@ -2162,7 +2162,7 @@ pg_stat_get_replication_slot(PG_FUNCTION_ARGS) INT8OID, -1, 0); TupleDescInitEntry(tupdesc, (AttrNumber) 11, "slotsync_skip_count", INT8OID, -1, 0); - TupleDescInitEntry(tupdesc, (AttrNumber) 12, "slotsync_skip_at", + TupleDescInitEntry(tupdesc, (AttrNumber) 12, "slotsync_last_skip", TIMESTAMPTZOID, -1, 0); TupleDescInitEntry(tupdesc, (AttrNumber) 13, "stats_reset", TIMESTAMPTZOID, -1, 0); @@ -2192,10 +2192,10 @@ pg_stat_get_replication_slot(PG_FUNCTION_ARGS) values[9] = Int64GetDatum(slotent->total_bytes); values[10] = Int64GetDatum(slotent->slotsync_skip_count); - if (slotent->slotsync_skip_at == 0) + if (slotent->slotsync_last_skip == 0) nulls[11] = true; else - values[11] = TimestampTzGetDatum(slotent->slotsync_skip_at); + values[11] = TimestampTzGetDatum(slotent->slotsync_last_skip); if (slotent->stat_reset_timestamp == 0) nulls[12] = true; diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index 66af2d96d67..fd9448ec7b9 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -5693,7 +5693,7 @@ proparallel => 'r', prorettype => 'record', proargtypes => 'text', proallargtypes => '{text,text,int8,int8,int8,int8,int8,int8,int8,int8,int8,int8,timestamptz,timestamptz}', proargmodes => '{i,o,o,o,o,o,o,o,o,o,o,o,o,o}', - proargnames => '{slot_name,slot_name,spill_txns,spill_count,spill_bytes,stream_txns,stream_count,stream_bytes,mem_exceeded_count,total_txns,total_bytes,slotsync_skip_count,slotsync_skip_at,stats_reset}', + proargnames => '{slot_name,slot_name,spill_txns,spill_count,spill_bytes,stream_txns,stream_count,stream_bytes,mem_exceeded_count,total_txns,total_bytes,slotsync_skip_count,slotsync_last_skip,stats_reset}', prosrc => 'pg_stat_get_replication_slot' }, { oid => '6230', descr => 'statistics: check if a stats object exists', diff --git a/src/include/pgstat.h b/src/include/pgstat.h index ad85134f27a..f23dd5870da 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -401,7 +401,7 @@ typedef struct PgStat_StatReplSlotEntry PgStat_Counter total_txns; PgStat_Counter total_bytes; PgStat_Counter slotsync_skip_count; - TimestampTz slotsync_skip_at; + TimestampTz slotsync_last_skip; TimestampTz stat_reset_timestamp; } PgStat_StatReplSlotEntry; diff --git a/src/test/regress/expected/rules.out b/src/test/regress/expected/rules.out index 94e45dd4d57..85d795dbd63 100644 --- a/src/test/regress/expected/rules.out +++ b/src/test/regress/expected/rules.out @@ -2153,10 +2153,10 @@ pg_stat_replication_slots| SELECT s.slot_name, s.total_txns, s.total_bytes, s.slotsync_skip_count, - s.slotsync_skip_at, + s.slotsync_last_skip, s.stats_reset FROM pg_replication_slots r, - LATERAL pg_stat_get_replication_slot((r.slot_name)::text) s(slot_name, spill_txns, spill_count, spill_bytes, stream_txns, stream_count, stream_bytes, mem_exceeded_count, total_txns, total_bytes, slotsync_skip_count, slotsync_skip_at, stats_reset) + LATERAL pg_stat_get_replication_slot((r.slot_name)::text) s(slot_name, spill_txns, spill_count, spill_bytes, stream_txns, stream_count, stream_bytes, mem_exceeded_count, total_txns, total_bytes, slotsync_skip_count, slotsync_last_skip, stats_reset) WHERE (r.datoid IS NOT NULL); pg_stat_slru| SELECT name, blks_zeroed, -- 2.34.1