Hi,
Patch v15-0001-ALTER-TABLE-MERGE-PARTITIONS-command.patch
Apply nicely.
One warning on meson compile (configure -Dssl=openssl -Dldap=enabled
-Dauto_features=enabled -DPG_TEST_EXTRA='ssl,ldap,kerberos' -Dbsd_auth=disabled
-Dbonjour=disabled -Dpam=disabled -Dpltcl=disabled -Dsystemd=disabled
-Dzstd=disabled -Db_coverage=true)
../../src/pgmergesplit/src/test/modules/test_ddl_deparse/test_ddl_deparse.c: In
function ‘get_altertable_subcmdinfo’:
../../src/pgmergesplit/src/test/modules/test_ddl_deparse/test_ddl_deparse.c:112:17:
warning: enumeration value ‘AT_MergePartitions’ not handled in switch
[-Wswitch]
112 | switch (subcmd->subtype)
| ^~~~~~
Should be the same with 0002...
meson test perfect, patch coverage is very good.
Patch v15-0002-ALTER-TABLE-SPLIT-PARTITION-command.patch
Doesn't apply on 326a33a289c7ba2dbf45f17e610b7be98dc11f67
Patch v15-0003-Documentation-for-ALTER-TABLE-SPLIT-PARTITION-ME.patch
Apply with one warning 1 line add space error (translate from french "warning:
1 ligne a ajouté des erreurs d'espace").
v15-0003-Documentation-for-ALTER-TABLE-SPLIT-PARTITION-ME.patch:54: trailing
whitespace.
One of the new partitions <replaceable
class="parameter">partition_name1</replaceable>,
Comment are ok for me. A non native english speaker.
Perhaps you could add some remarks in ddl.html and alter-ddl.html
Stéphane
The new status of this patch is: Waiting on Author
