From 1f6ec019b5c9c9eebe1ba25043dfc7b4677d07d3 Mon Sep 17 00:00:00 2001 From: Hayato Kuroda Date: Fri, 24 Mar 2023 11:00:53 +0000 Subject: [PATCH v2 2/2] Add XML ID attributes to create_publication.sgml This commit adds XML ID attributes to all varlistentries in create_publication.sgml. Additionally, links are included to refer to publication options, making documents more readable. --- doc/src/sgml/logical-replication.sgml | 27 +++++++++++++---------- doc/src/sgml/ref/alter_publication.sgml | 6 ++--- doc/src/sgml/ref/create_publication.sgml | 14 ++++++------ doc/src/sgml/ref/create_subscription.sgml | 23 ++++++++++--------- doc/src/sgml/system-views.sgml | 6 ++--- 5 files changed, 40 insertions(+), 36 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 4aa643ce94..5f361bf641 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -798,11 +798,12 @@ ALTER SUBSCRIPTION If the publication contains a partitioned table, the publication parameter - publish_via_partition_root determines which row filter - is used. If publish_via_partition_root is true, - the root partitioned table's row filter is used. Otherwise, - if publish_via_partition_root is false - (default), each partition's row filter is used. + publish_via_partition_root + determines which row filter is used. If publish_via_partition_root + is true, the root partitioned table's + row filter is used. Otherwise, if publish_via_partition_root + is false (default), each partition's + row filter is used. @@ -826,10 +827,11 @@ ALTER SUBSCRIPTION Because initial data synchronization does not take into account the - publish parameter when copying existing table data, - some rows may be copied that would not be replicated using DML. Refer to - , and see - for examples. + publish + parameter when copying existing table data, some rows may be copied that + would not be replicated using DML. Refer to , + and see for + examples. @@ -860,15 +862,16 @@ ALTER SUBSCRIPTION - One of the publications was created using FOR ALL TABLES. + One of the publications was created using FOR ALL TABLES. This clause does not allow row filters. One of the publications was created using - FOR TABLES IN SCHEMA and the table belongs to - the referred schema. This clause does not allow row filters. + FOR TABLES IN SCHEMA + and the table belongs to the referred schema. This clause does not allow + row filters. diff --git a/doc/src/sgml/ref/alter_publication.sgml b/doc/src/sgml/ref/alter_publication.sgml index cd20868bca..a37bb734b7 100644 --- a/doc/src/sgml/ref/alter_publication.sgml +++ b/doc/src/sgml/ref/alter_publication.sgml @@ -54,7 +54,7 @@ ALTER PUBLICATION name RENAME TO ALTER SUBSCRIPTION ... REFRESH PUBLICATION action on the subscribing side in order to become effective. Note also that DROP TABLES IN SCHEMA will not drop any schema tables - that were specified using FOR TABLE/ + that were specified using FOR TABLE/ ADD TABLE, and the combination of DROP with a WHERE clause is not allowed. @@ -79,8 +79,8 @@ ALTER PUBLICATION name RENAME TO SET ROLE to the new owning role, and that role must have CREATE privilege on the database. - Also, the new owner of a FOR ALL TABLES or - FOR TABLES IN SCHEMA + Also, the new owner of a FOR ALL TABLES + or FOR TABLES IN SCHEMA publication must be a superuser. However, a superuser can change the ownership of a publication regardless of these restrictions. diff --git a/doc/src/sgml/ref/create_publication.sgml b/doc/src/sgml/ref/create_publication.sgml index a2946feaa3..1cea8b4563 100644 --- a/doc/src/sgml/ref/create_publication.sgml +++ b/doc/src/sgml/ref/create_publication.sgml @@ -54,7 +54,7 @@ CREATE PUBLICATION name Parameters - + name @@ -63,7 +63,7 @@ CREATE PUBLICATION name - + FOR TABLE @@ -117,7 +117,7 @@ CREATE PUBLICATION name - + FOR ALL TABLES @@ -127,7 +127,7 @@ CREATE PUBLICATION name - + FOR TABLES IN SCHEMA @@ -158,7 +158,7 @@ CREATE PUBLICATION name - + WITH ( publication_parameter [= value] [, ... ] ) @@ -166,7 +166,7 @@ CREATE PUBLICATION name following parameters are supported: - + publish (string) @@ -188,7 +188,7 @@ CREATE PUBLICATION name - + publish_via_partition_root (boolean) diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index a66b8025f3..f4c62c5698 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -418,17 +418,18 @@ CREATE SUBSCRIPTION subscription_nameWHERE clauses, if one of the publications has no WHERE clause (referring to that publish operation) or the publication is declared as - FOR ALL TABLES or - FOR TABLES IN SCHEMA, rows are always published - regardless of the definition of the other expressions. - If the subscriber is a PostgreSQL version before - 15, then any row filtering is ignored during the initial data synchronization - phase. For this case, the user might want to consider deleting any initially - copied data that would be incompatible with subsequent filtering. - Because initial data synchronization does not take into account the publication - publish parameter when copying existing table data, some rows - may be copied that would not be replicated using DML. See - for examples. + FOR ALL TABLES + or FOR TABLES IN SCHEMA, + rows are always published regardless of the definition of the other + expressions. If the subscriber is a PostgreSQL + version before 15, then any row filtering is ignored during the initial data + synchronization phase. For this case, the user might want to consider + deleting any initially copied data that would be incompatible with + subsequent filtering. Because initial data synchronization does not take + into account the publication publish + parameter when copying existing table data, some rows may be copied that + would not be replicated using DML. See + for examples. diff --git a/doc/src/sgml/system-views.sgml b/doc/src/sgml/system-views.sgml index 7c8fc3f654..a6e50dbadb 100644 --- a/doc/src/sgml/system-views.sgml +++ b/doc/src/sgml/system-views.sgml @@ -2145,9 +2145,9 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx information about the mapping between publications and information of tables they contain. Unlike the underlying catalog pg_publication_rel, - this view expands publications defined as FOR ALL TABLES - and FOR TABLES IN SCHEMA, so for such publications - there will be a row for each eligible table. + this view expands publications defined as FOR ALL TABLES + and FOR TABLES IN SCHEMA, + so for such publications there will be a row for each eligible table. -- 2.27.0