Fix attnum remapping in generateClonedExtStatsStmt() When cloning extended statistics via CREATE TABLE ... LIKE ... INCLUDING STATISTICS, stxkeys holds attribute numbers from the source (parent) table, but get_attname() was being called with the child relation's OID. If the parent has dropped columns, the child's attribute numbers are renumbered sequentially and no longer match, so the lookup either returns the wrong column name (silent corruption) or errors out when the attnum does not exist in the child.
Fix it by remapping the parent attnum through attmap before the lookup, consistent with how expression statistics are already handled a few lines below. Add a regression test covering both manifestations: a 3-column parent where the stale attnum refers to no child column (cache-lookup error), and a 4-column parent where the stale attnum silently refers to the wrong child column. Author: Julien Tachoires <[email protected]> Reviewed-by: Srinath Reddy Sadipiralla <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/76d15a7ee9de91afda672cd7ed56cdcd9909f4ef Modified Files -------------- src/backend/parser/parse_utilcmd.c | 8 +++++-- src/test/regress/expected/create_table_like.out | 31 +++++++++++++++++++++++++ src/test/regress/sql/create_table_like.sql | 26 +++++++++++++++++++++ 3 files changed, 63 insertions(+), 2 deletions(-)
