Fix xid_advance_interval when max_retention_duration is 0. When a subscription has retain_dead_tuples enabled and maxretention is zero (unlimited), adjust_xid_advance_interval() mistakenly caps xid_advance_interval to zero.
This zero interval forces get_candidate_xid() to evaluate TimestampDifferenceExceeds() as always true, causing the apply worker to call GetOldestActiveTransactionId() for every WAL message. This leads to unnecessary ProcArrayLock acquisitions. Fix this by only capping the interval when maxretention > 0, allowing the exponential back-off to function properly. Author: SATYANARAYANA NARLAPURAM <[email protected]> Reviewed-by: shveta malik <[email protected]> Reviewed-by: Nisha Moond <[email protected]> Discussion: https://postgr.es/m/CAHg+QDdKVnCLHot=acoppeisydzgz7wgyjafhvow57odtmu...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c210647aeb17692c138014235c7e7a2d9af73b87 Modified Files -------------- src/backend/replication/logical/worker.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
