Hi John, > Separate out bytea sort support from varlena.c > > [...]
I noticed that the ByteaSortSupport.abbreviate field is not used for anything. Here is the fix. -- Best regards, Aleksander Alekseev
From 1479ca013ee7e4655105b112d0ec3cc2cf008890 Mon Sep 17 00:00:00 2001 From: Aleksander Alekseev <[email protected]> Date: Tue, 14 Apr 2026 17:44:21 +0300 Subject: [PATCH v1] Remove unused ByteaSortSupport.abbreviate field Oversight of commit 9303d62c6db0. Author: Aleksander Alekseev <[email protected]> Discussion: https://postgr.es/m/CAJ7c6TP1bAbEhUJa6+rgceN6QJWMSsxhg1=mqfSN=nb-n6d...@mail.gmail.com --- src/backend/utils/adt/bytea.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/backend/utils/adt/bytea.c b/src/backend/utils/adt/bytea.c index f6e3266ac32..a1f5d4e572b 100644 --- a/src/backend/utils/adt/bytea.c +++ b/src/backend/utils/adt/bytea.c @@ -41,7 +41,6 @@ static bytea *bytea_overlay(bytea *t1, bytea *t2, int sp, int sl); typedef struct { - bool abbreviate; /* Should we abbreviate keys? */ hyperLogLogState abbr_card; /* Abbreviated key cardinality state */ hyperLogLogState full_card; /* Full key cardinality state */ double prop_card; /* Required cardinality proportion */ @@ -1229,7 +1228,6 @@ bytea_sortsupport(PG_FUNCTION_ARGS) ByteaSortSupport *bss; bss = palloc_object(ByteaSortSupport); - bss->abbreviate = true; bss->prop_card = 0.20; initHyperLogLog(&bss->abbr_card, 10); initHyperLogLog(&bss->full_card, 10); -- 2.43.0
