Add nkeys parameter to recheck_matched_pk_tuple() The function looped over ii_NumIndexKeyAttrs elements of the skeys array, but one caller (ri_FastPathFlushArray) passes a one-element array since it only handles single-column FKs. The function signature did not communicate this constraint, which static analysis flags as a potential out-of-bounds read.
Add an nkeys parameter and assert that it matches ii_NumIndexKeyAttrs, then use it in the loop. The call sites already know the key count. Reported-by: Evan Montgomery-Recht <[email protected]> Discussion: https://postgr.es/m/caeg7pwckf01fmdqfaf-hzu_pynmyscy_otid-pe9uw3bj6g...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e1cc57fabd6c32fcb740d62da90443f8c708951e Modified Files -------------- src/backend/utils/adt/ri_triggers.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
