Remove bogus "safety margin" from predicate.c shmem estimates The 10% safety margin was copy-pasted from lock.c when the predicate locking code was originally added. However, we later (commit 7c797e7194) added the HASH_FIXED_SIZE flag to the hash tables, which means that they cannot actually use the safety margin that we're calculating for them.
The extra memory was mainly used by the main lock manager, which is the only shmem hash table of non-trivial size that does not use the HASH_FIXED_SIZE flag. If we wanted to have more space for the lock manager, we should reserve it directly in lock.c. After this commit, the lock manager will just have less memory available than before. Reviewed-by: Ashutosh Bapat <[email protected]> Reviewed-by: Matthias van de Meent <[email protected]> Discussion: https://www.postgresql.org/message-id/[email protected] Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/feb03dfecdc9810619bc94793be3257a487a669f Modified Files -------------- src/backend/storage/lmgr/predicate.c | 6 ------ 1 file changed, 6 deletions(-)
