perl tap: Use croak instead of die in our helper modules Replace die with croak throughout Cluster.pm and Utils.pm (except in INIT blocks and signal handlers, where die is correct) so that error messages report the test script's line number rather than the helper module's.
Add @CARP_NOT in Utils.pm listing PostgreSQL::Test::Cluster, so that when a Utils function is called through a Cluster.pm wrapper, croak skips both packages and reports the actual test-script caller. Author: Jelte Fennema-Nio <[email protected]> Reviewed-by: Andrew Dunstan <[email protected]> Reviewed-by: Corey Huinker <[email protected]> Reviewed-by: Zsolt Parragi <[email protected]> Reviewed-by: Nazir Bilal Yavuz <[email protected]> Reviewed-by: Andres Freund <[email protected]> Discussion: https://postgr.es/m/[email protected] Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b8da9869b850246ea047038fb974830269b83bcc Modified Files -------------- src/test/perl/PostgreSQL/Test/Cluster.pm | 108 +++++++++++++++---------------- src/test/perl/PostgreSQL/Test/Utils.pm | 30 +++++---- 2 files changed, 71 insertions(+), 67 deletions(-)
