On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby <[email protected]> wrote: > If I'm not wrong, this is causing failures on cfbot. > https://cirrus-ci.com/task/6312181619752960?logs=build#L2056 > > [17:24:48.348] c:\cirrus\src\backend\replication\basebackup_gzip.c(90): > warning C4715: 'bbsink_gzip_new': not all control paths return a value > [c:\cirrus\postgres.vcxproj] > [17:24:48.348] c:\cirrus\src\bin\pg_basebackup\pg_basebackup.c(1922,67): > error C2065: 'Z_DEFAULT_COMPRESSION': undeclared identifier > [c:\cirrus\pg_basebackup.vcxproj] > > The warning seems to be what's fixed by David's patch here. > https://www.postgresql.org/message-id/CA%2BTgmobSeRFM84pwa5HfZCGRx%3DQ-iFfPFZfq-4%3Dt1p04yxg_Og%40mail.gmail.com
I can commit that patch (though so could David) but I don't understand why you think it's connected to this commit particularly. -- Robert Haas EDB: http://www.enterprisedb.com
