On Tue, Jun 30, 2020 at 12:56 PM MUKKUND SUNJII <mukkundsun...@gmail.com> wrote:
> Greetings, > > I am a master’s student in TU Delft, The Netherlands, and I am carrying > out my thesis using the adaptive mesh refinement solver provided in > ./ts/tutorials/ex11.c. > > In the process of my work, I have added a HLL Riemann Solver for the > shallow water equation. I had already tested and validated the Riemann > Solver using several cases (I am happy to provide a copy of my thesis > report). It would indeed be nice to see my work reflected in the current > version of ex11.c as an addition to its capability. > > Furthermore, I had also added a Riemann Solver that contains topography > terms and is well-balanced*. The caveat is that I see that there some > variations in the well-balancedness when choosing between p4est and Plex > DM’s. Perhaps, this could be looked at and fixed in the future. > > The purpose of this email is to propose the addition of the HLL Riemann > Solver for the shallow water equations to ex11.c and perhaps later explore > the possibility of adding the Riemann Solver with the bathymetry terms. > > I have already gone through the CI process instituted by PETSc (previously > integrated ./ts/tutorials/ex54.c into the repository with the valuable > assistance of Mr. Satish Balay). Hence, I would be more or less familiar > with the process. > > I kindly ask you provide any feedback on this proposition. > Yes, this sounds great to me. Thanks, Matt > Regards, > > Mukkund Sunjii -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener https://www.cse.buffalo.edu/~knepley/ <http://www.cse.buffalo.edu/~knepley/>