Tue Jun 12 15:09:54 2018: Request 125503 was acted upon.
Transaction: Correspondence added by RSCHUPP
Queue: PAR-Packer
Subject: [PATCH] Fix build with 64-bit perl-5.28.0
Broken in: 1.043
Severity: (no value)
Owner: Nobody
Requestors: [email protected]
Status: new
Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=125503 >
On 2018-06-08 05:04:20, SHAY wrote:
> I found another problem: Executables compiled with pp's -C argument
> crashed on exit due to another 64-bit bug, in par_rmtmpdir(). The
> _findfirst() function returns an intptr_t (a 32-bit integer in x86
> builds, but 64-bit in x64 builds -- to hold the larger pointers) but
> it was being assigned to a long (a 32-bit integer in both x86 and x64
> builds), so it got truncated.
>
> I've also spotted one more use of struct stat which I think needs
> changing to par_stat_t, which is also done in this updated patch. I
> haven't tested this change myself since it affects only the non-WIN32
> version of par_rmtmpdir(), so please be sure to test with the -C
> argument on a x64 build on some non-WIN32 platform.
Merged the second half of your patch (a fix similar to your first half was
already applied in 1.044) and released as 1.045. Thanks, Steve!
Cheers. Roderich
