Pan is currently failing to build here, bisected to current HEAD-1: * commit bbdd7111f28216319677cb391e2f149789aa8208 Author: Dominique Dumont <domi.dum...@free.fr> AuthorDate: Sun Mar 30 18:40:56 2025 +0200 Commit: Dominique Dumont <domi.dum...@free.fr> CommitDate: Sun Mar 30 19:41:56 2025 +0200
The cmake error: >>>> CMake Error at pan/data-impl/CMakeLists.txt:1 (add_library): Cannot find source file: article-rules.cc CMake Error at pan/data-impl/CMakeLists.txt:1 (add_library): No SOURCES given to target: data-impl <<<< Meanwhile, in my function as the de facto list "pan historian" as someone once called me, some commentary on the commit rationale link discussion: https://gitlab.gnome.org/GNOME/pan/-/issues/162 > However, the __OR variant is never used, and the __AND code is used to > support a list of rules and it totally ignores the result of applying > any rule. I noticed some time ago that the as-documented-in-original-clients OR behavior seemed to be absent. Only AND worked. This is probably why. (Contrary to the implication of the above the AND code worked. Not being a coder so just relying on the above comment and pan behavior, I'm assuming the "totally ignores the result" bit may be because the result is only later applied based on other conditions.) AFAIK the OR never worked, or at least never did when I tested, which admittedly wasn't that often, both because I seldom needed OR, and because after the first time I tried it I "knew" it was broken. I'm assuming Charles meant to implement the OR side later once he got the AND code working and tested, and just never got to it. Also, the rules functionality was somewhat obscure and only somewhat practical as Charles implemented it as well, likely contributing to original low usage and obscurity. Heinrich made it much more functional/ practical based on a UI proposal I made, but of course news has never been "mainline" (which of course for binaries in particular has made it /more/ attractive for those actually using it because it has avoided much of the legal copyright/moral censorship pressure imposed on more mainline peer2peer and web distribution), and by the time that was introduced news was already well on the decline from its never-mainline heights, so rules likely never got /that/ much usage, and of those that used rules at all, even fewer had reason to try the OR functionality and ever realize it was broken. (I haven't actually looked at mentioned TODOs in the mentioned branch; maybe you mention the missing OR implementation there?) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman _______________________________________________ Pan-users mailing list Pan-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/pan-users
