https://bugzilla.redhat.com/show_bug.cgi?id=2468312
--- Comment #49 from Dominik 'Rathann' Mierzejewski <[email protected]> --- I have some additional comments (not blockers, but it'd be good to address): Please split BuildRequires: into separate lines and sort alphabetically. It makes future diffs cleaner. rm -rf src/ui/Windows rm -rf src/os/windows rm -rf src/os/mac Use rm -rv. -f makes it not fail if the files are missing in a future tarball. dos2unix config.txt dos2unix help.txt Please use dos2unix -k to keep the timestaps of the original files (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps). Would it make sense to split pwsafe or pwsafe-cli to separate (sub-)package? Some admins like to avoid installing GUI libraries on headless servers if they can. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2468312 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202468312%23c49 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
