https://bugzilla.redhat.com/show_bug.cgi?id=2445636
--- Comment #22 from [email protected] --- Made the following changes: * Added bundled libs as Provides: * Fixed unowned directory for icons/hicolor/scalable/apps * Used desktop-file-install * moved /usr/share files into -data subpackage * enabled %ctest, disabled python tests because I can't see an easy way to enable venv within the build process SRPM: https://mumble07.fedorapeople.org/SRPMS/OpenVSP-3.50.3-1.fc45.src.rpm SPEC: https://github.com/Mumbri-systems/OpenVSP/raw/openvsp-fedora/pkg/rpm/OpenVSP.spec rmplint finds the following errors: Rpmlint ------- Checking: OpenVSP-3.50.3-1.fc45.x86_64.rpm OpenVSP-data-3.50.3-1.fc45.noarch.rpm OpenVSP-3.50.3-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpni0vys1e')] checks: 32, packages: 3 OpenVSP.spec:59: W: unversioned-explicit-provides angelscript OpenVSP.spec:60: W: unversioned-explicit-provides fltk OpenVSP.spec:61: W: unversioned-explicit-provides cpptest OpenVSP.spec:62: W: unversioned-explicit-provides Code-Eli OpenVSP.spec:63: W: unversioned-explicit-provides delabella OpenVSP.spec:64: W: unversioned-explicit-provides exprparse OpenVSP.spec:65: W: unversioned-explicit-provides libiges OpenVSP.spec:66: W: unversioned-explicit-provides openabf OpenVSP.spec:67: W: unversioned-explicit-provides Pinocchio OpenVSP.spec:68: W: unversioned-explicit-provides Triangle OpenVSP.x86_64: W: no-manual-page-for-binary vsp OpenVSP.x86_64: W: no-manual-page-for-binary vspaero OpenVSP.x86_64: W: no-manual-page-for-binary vspaero_opt OpenVSP.x86_64: W: no-manual-page-for-binary vsploads OpenVSP.x86_64: W: no-manual-page-for-binary vspscript OpenVSP.x86_64: W: no-manual-page-for-binary vspviewer OpenVSP-data.noarch: W: no-documentation OpenVSP.src: W: invalid-license NASA-1.3 OpenVSP.x86_64: W: invalid-license NASA-1.3 OpenVSP-data.noarch: W: invalid-license NASA-1.3 OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/AdvLink.html /usr/help/AdvLink.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/AttributeExplorer.html /usr/help/AttributeExplorer.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/GeometryAnalysis.html /usr/help/GeometryAnalysis.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/SetEdit.html /usr/help/SetEdit.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/StackPresets.html /usr/help/StackPresets.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/github-pandoc.css /usr/help/github-pandoc.css OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/AdvLink_example.png /usr/help/images/AdvLink_example.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineDefinition.png /usr/help/images/EngineDefinition.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineNacelleOnly.png /usr/help/images/EngineNacelleOnly.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineNacelleWithNegativeFlowpath.png /usr/help/images/EngineNacelleWithNegativeFlowpath.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineNegativeFlowpathOnly.png /usr/help/images/EngineNegativeFlowpathOnly.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineRepresentation.png /usr/help/images/EngineRepresentation.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineStations.png /usr/help/images/EngineStations.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowpathInlet.png /usr/help/images/NacelleFlowpathInlet.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowpathInletOutlet.png /usr/help/images/NacelleFlowpathInletOutlet.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowpathOutlet.png /usr/help/images/NacelleFlowpathOutlet.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowthruInletOrigin.png /usr/help/images/NacelleFlowthruInletOrigin.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowthruMidOrigin.png /usr/help/images/NacelleFlowthruMidOrigin.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowthruOutletOrigin.png /usr/help/images/NacelleFlowthruOutletOrigin.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletFaceOutletLip.png /usr/help/images/NacelleInletFaceOutletLip.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletLipOutletFace.png /usr/help/images/NacelleInletLipOutletFace.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletOutletFace.png /usr/help/images/NacelleInletOutletFace.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletOutletToLip.png /usr/help/images/NacelleInletOutletToLip.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletToFace.png /usr/help/images/NacelleInletToFace.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletToLip.png /usr/help/images/NacelleInletToLip.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleOutletToFace.png /usr/help/images/NacelleOutletToFace.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleOutletToLip.png /usr/help/images/NacelleOutletToLip.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/SetEditor_body.png /usr/help/images/SetEditor_body.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/SetEditor_footer.png /usr/help/images/SetEditor_footer.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/SetEditor_header.png /usr/help/images/SetEditor_header.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/SetEditor_window.png /usr/help/images/SetEditor_window.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/index.html /usr/help/index.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/vsp_help /usr/help/vsp_help OpenVSP.x86_64: W: files-duplicate /usr/share/doc/VSP/README.md /usr/share/doc/OpenVSP/README.md OpenVSP.x86_64: W: files-duplicate /usr/share/licenses/OpenVSP/LICENSE /usr/share/doc/VSP/LICENSE OpenVSP-data.noarch: W: desktopfile-without-binary /usr/share/applications/openvsp.desktop /usr/bin/vsp 3 packages and 0 specfiles checked; 33 errors, 23 warnings, 46 filtered, 33 badness; has taken 8.2 s I think I found the offending file in https://github.com/Mumbri-systems/OpenVSP/raw/openvsp-fedora/src/help/CMakeLists.txt I don't understand how copying is leading to bad hardlinks, or how to fix it. The only reference I can find is this: https://docs.fedoraproject.org/en-US/fedora/latest/release-notes/developers/#_hardlink_identical_files_in_packages_by_default Guidance would be appreciated. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2445636 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445636%23c22 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
