https://bugzilla.redhat.com/show_bug.cgi?id=2463848

Zbigniew Jędrzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #22 from Zbigniew Jędrzejewski-Szmek <[email protected]> ---
Those manual changelogs are nowadays unnecessary… You might want to switch to
https://fedora-infra.github.io/rpmautospec-docs/opting-in.html.

/usr/bin/cargo2rpm, /usr/bin/env, /usr/bin/cargo can be written without the
paths.
(Actually, the call to env is unnecessary. Plain
  CARGO_HOME=.cargo RUSTC_BOOTSTRAP=1 cargo test ...
works too.)

Don't use %bcond_without, use '%bcond check 1' instead.

install -D -m 644 man/hwatch.1 %{buildroot}%{_mandir}/man1/%{name}.1
→ install -D -m 644 man/hwatch.1 -t %{buildroot}%{_mandir}/man1/
to avoid repeating stuff. The same for all the other install commands.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2463848

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463848%23c22

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to