https://bugzilla.redhat.com/show_bug.cgi?id=2466648
Petr Pisar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?([email protected] | |) | --- Comment #5 from Petr Pisar <[email protected]> --- URL and Source0 addresses are usable. Ok. Source0 archive (SHA-512: 84038bedfc059113cde19744164278059bb59d71b9d90fedd814a08e30a5b534e5d7af24d8b56ed179217e91a0469f48d62484b51b9ca0180b90ac861871ef9d) is original. Ok. Summary verified from cmake4.pm. Ok. Description verified from cmake4.pm. Ok. TODO: I recommend spelling "cmake" as "CMake". See <https://cmake.org/>. License verified from LICENSE, cmake4.pm, and README. Ok. TODO: Constrain "perl(alienfile)" build-dependency with ">= 1.40" (META.json:44). Why does "perl(Alien::Base)" dependency have minimal version 0.92 if there is no such constraint in the sources? All tests pass. Ok. $ rpmlint perl-Alien-cmake4.spec ../SRPMS/perl-Alien-cmake4-0.04-1.fc45.src.rpm ../RPMS/x86_64/perl-Alien-cmake4-0.04-1.fc45.x86_64.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Alien-cmake4.x86_64: E: spelling-error ('autoconf', '%description -l en_US autoconf -> automaton') perl-Alien-cmake4.src: E: spelling-error ('autoconf', '%description -l en_US autoconf -> automaton') perl-Alien-cmake4.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Alien-cmake4/LICENSE === 2 packages and 1 specfiles checked; 3 errors, 0 warnings, 6 filtered, 3 badness; has taken 0.6 s == rpmlint is Ok. TODO: Report upstream that the GPL license text has out-dated Free Software Foundation's address. $ rpm -q -lv -p ../RPMS/x86_64/perl-Alien-cmake4-0.04-1.fc45.x86_64.rpm drwxr-xr-x 2 root root 0 May 26 02:00 /usr/lib64/perl5/vendor_perl/Alien -rw-r--r-- 1 root root 4237 May 5 16:39 /usr/lib64/perl5/vendor_perl/Alien/cmake4.pm drwxr-xr-x 2 root root 0 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/Alien drwxr-xr-x 2 root root 0 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/Alien/cmake4 -rw-r--r-- 1 root root 65 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/Alien/cmake4/cmake4.txt drwxr-xr-x 2 root root 0 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/share drwxr-xr-x 2 root root 0 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/share/dist drwxr-xr-x 2 root root 0 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-cmake4 drwxr-xr-x 2 root root 0 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-cmake4/_alien -rw-r--r-- 1 root root 427 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-cmake4/_alien/alien.json -rw-r--r-- 1 root root 3352 May 26 02:00 /usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-cmake4/_alien/alienfile drwxr-xr-x 2 root root 0 May 26 02:00 /usr/share/doc/perl-Alien-cmake4 -rw-r--r-- 1 root root 523 May 5 17:30 /usr/share/doc/perl-Alien-cmake4/Changes -rw-r--r-- 1 root root 4516 Apr 24 11:08 /usr/share/doc/perl-Alien-cmake4/README.md drwxr-xr-x 2 root root 0 May 26 02:00 /usr/share/licenses/perl-Alien-cmake4 -rw-r--r-- 1 root root 19752 Apr 21 15:09 /usr/share/licenses/perl-Alien-cmake4/LICENSE -rw-r--r-- 1 root root 2667 May 26 02:00 /usr/share/man/man3/Alien::cmake4.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Alien-cmake4-0.04-1.fc45.x86_64.rpm | sort -f | uniq -c 1 cmake >= 4.0.0 1 perl(:VERSION) >= 5.8.1 1 perl(Alien::Base) >= 0.92 1 perl(parent) 1 perl(Path::Tiny) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Alien-cmake4-0.04-1.fc45.x86_64.rpm | sort -f | uniq -c 1 perl(Alien::cmake4) = 0.04 1 perl-Alien-cmake4 = 0.04-1.fc45 1 perl-Alien-cmake4(x86-64) = 0.04-1.fc45 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Alien-cmake4-0.04-1.fc45.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in F45 (https://koji.fedoraproject.org/koji/taskinfo?taskID=146020820). Ok. The package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items before building this package. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2466648 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202466648%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
